From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NHInE-0007z4-V0 for qemu-devel@nongnu.org; Sun, 06 Dec 2009 10:13:00 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NHIn9-0007tl-Og for qemu-devel@nongnu.org; Sun, 06 Dec 2009 10:13:00 -0500 Received: from [199.232.76.173] (port=53327 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NHIn9-0007tO-Hf for qemu-devel@nongnu.org; Sun, 06 Dec 2009 10:12:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:8659) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NHIn9-0004hy-7R for qemu-devel@nongnu.org; Sun, 06 Dec 2009 10:12:55 -0500 Message-ID: <4B1BC9F4.2030008@redhat.com> Date: Sun, 06 Dec 2009 17:12:52 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] kvm: x86: Fix initial kvm_has_msr_star References: <4B1BC4EC.90704@web.de> In-Reply-To: <4B1BC4EC.90704@web.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , Marcelo Tosatti , qemu-devel On 12/06/2009 04:51 PM, Jan Kiszka wrote: > KVM_GET_MSR_INDEX_LIST returns -E2BIG when the provided space is too > small for all MSRs. But this is precisely the error we trigger with the > initial request in order to obtain that size. Do not fail in that case. > > This caused a subtle corruption of the guest state as MSR_STAR was not > properly saved/restored. The corruption became visible with latest kvm > optimizing the MSR updates. > Strong ack. Anthony, please apply ASAP. This is worthy of a 0.11.2, IMO. -- error compiling committee.c: too many arguments to function