From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NHYiK-0001EM-Ul for qemu-devel@nongnu.org; Mon, 07 Dec 2009 03:13:00 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NHYiF-0001C0-6I for qemu-devel@nongnu.org; Mon, 07 Dec 2009 03:12:59 -0500 Received: from [199.232.76.173] (port=42365 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NHYiF-0001Bf-00 for qemu-devel@nongnu.org; Mon, 07 Dec 2009 03:12:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18015) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NHYiE-0002Wn-Jv for qemu-devel@nongnu.org; Mon, 07 Dec 2009 03:12:54 -0500 Message-ID: <4B1CB903.9000900@redhat.com> Date: Mon, 07 Dec 2009 10:12:51 +0200 From: Avi Kivity MIME-Version: 1.0 References: <4B1BC4EC.90704@web.de> In-Reply-To: <4B1BC4EC.90704@web.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] kvm: x86: Fix initial kvm_has_msr_star List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , Marcelo Tosatti , qemu-devel On 12/06/2009 04:51 PM, Jan Kiszka wrote: > KVM_GET_MSR_INDEX_LIST returns -E2BIG when the provided space is too > small for all MSRs. But this is precisely the error we trigger with the > initial request in order to obtain that size. Do not fail in that case. > > This caused a subtle corruption of the guest state as MSR_STAR was not > properly saved/restored. The corruption became visible with latest kvm > optimizing the MSR updates. > I applied this to qemu-kvm since it missed 0.12-rc1. -- error compiling committee.c: too many arguments to function