From: Gerd Hoffmann <kraxel@redhat.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V8 00/18] split out piix specific part from pc emulator
Date: Mon, 07 Dec 2009 10:40:46 +0100 [thread overview]
Message-ID: <4B1CCD9E.4060402@redhat.com> (raw)
In-Reply-To: <20091205002058.GC3670@valinux.co.jp>
On 12/05/09 01:20, Isaku Yamahata wrote:
> On Fri, Dec 04, 2009 at 08:09:35AM -0600, Anthony Liguori wrote:
>> Isaku Yamahata wrote:
>>> This is the preparation patch for q35 chipset and PCIE support.
>>> Anthony, any chance to merge? Can you please give me comments?
>>>
>>
>> I'd like to see Michael review the PCI changes and Gerd review the pc
>> changes.
>>
>> I'm uncertain if some of the pc refactoring is the right intermediate
>> solution verses just doing the right thing from a qdev perspective.
>
> However when will the final conversion take place?
> It would take long. Another several months or a year is
> surely worth while for the intermediate solution.
> I've already waited for several months vainly. I think the intermediate
> solution is definitively worth while.
I agree here. The patches untangle piix emulation and pc emulation.
This is needed for both q35 support and qdev conversion. Even though
these patches don't touch qdev bits much it is still a big step into the
right direction.
I have some minor nits only (see mails to some individual patches).
cheers,
Gerd
next prev parent reply other threads:[~2009-12-07 9:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 5:50 [Qemu-devel] [PATCH V8 00/18] split out piix specific part from pc emulator Isaku Yamahata
2009-12-04 5:50 ` [Qemu-devel] [PATCH V8 01/18] acpi: split out pc smbus routines from acpi.c into pc_smbus.c Isaku Yamahata
2009-12-04 5:50 ` [Qemu-devel] [PATCH V8 02/18] acpi: split out apm register emulation from acpi.c Isaku Yamahata
2009-12-07 9:07 ` [Qemu-devel] " Michael S. Tsirkin
2009-12-04 5:50 ` [Qemu-devel] [PATCH V8 03/18] acpi: add acpi constants from linux header files and use them Isaku Yamahata
2009-12-04 5:50 ` [Qemu-devel] [PATCH V8 04/18] acpi: split acpi.c into the common part and the piix4 part Isaku Yamahata
2009-12-04 5:50 ` [Qemu-devel] [PATCH V8 05/18] acpi_piix4: remove unused variable in get_pmsts() Isaku Yamahata
2009-12-04 5:50 ` [Qemu-devel] [PATCH V8 06/18] pc, i440fx: Make smm enable/disable function i440fx independent Isaku Yamahata
2009-12-04 5:50 ` [Qemu-devel] [PATCH V8 07/18] pc: make an unnecessary global variable, pit, local Isaku Yamahata
2009-12-04 5:50 ` [Qemu-devel] [PATCH V8 08/18] pc: remove a global variable, floppy_controller Isaku Yamahata
2009-12-04 5:50 ` [Qemu-devel] [PATCH V8 09/18] pc: remove a global variable, RTCState *rtc_state Isaku Yamahata
2009-12-07 9:15 ` Gerd Hoffmann
2009-12-09 2:44 ` Isaku Yamahata
2009-12-04 5:50 ` [Qemu-devel] [PATCH V8 10/18] pc: introduce a function to allocate cpu irq Isaku Yamahata
2009-12-04 5:50 ` [Qemu-devel] [PATCH V8 11/18] pc: make pc_init1() not refer ferr_irq directly Isaku Yamahata
2009-12-04 5:50 ` [Qemu-devel] [PATCH V8 12/18] pc: split out cpu initialization from pc_init1() into pc_cpus_init() Isaku Yamahata
2009-12-04 5:51 ` [Qemu-devel] [PATCH V8 13/18] pc: split out memory allocation from pc_init1() into pc_memory_init() Isaku Yamahata
2009-12-04 5:51 ` [Qemu-devel] [PATCH V8 14/18] pc: split out vga initialization from pc_init1() into pc_vga_init() Isaku Yamahata
2009-12-04 5:51 ` [Qemu-devel] [PATCH V8 15/18] pc: split out basic device init from pc_init1() into pc_basic_device_init() Isaku Yamahata
2009-12-04 5:51 ` [Qemu-devel] [PATCH V8 16/18] pc: split out pci device init from pc_init1() into pc_pci_device_init() Isaku Yamahata
2009-12-04 5:51 ` [Qemu-devel] [PATCH V8 17/18] pc: split out piix specific part from pc.c into pc_piix.c Isaku Yamahata
2009-12-04 5:51 ` [Qemu-devel] [PATCH V8 18/18] pc_piix: initialize ioapic before use Isaku Yamahata
2009-12-07 9:23 ` Gerd Hoffmann
2009-12-04 14:09 ` [Qemu-devel] [PATCH V8 00/18] split out piix specific part from pc emulator Anthony Liguori
2009-12-05 0:20 ` Isaku Yamahata
2009-12-07 9:40 ` Gerd Hoffmann [this message]
2009-12-07 9:07 ` [Qemu-devel] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1CCD9E.4060402@redhat.com \
--to=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).