From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NHa5S-0001fw-Az
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 04:40:58 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NHa5N-0001dy-FS
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 04:40:57 -0500
Received: from [199.232.76.173] (port=37435 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NHa5N-0001dv-9E
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 04:40:53 -0500
Received: from mx1.redhat.com ([209.132.183.28]:65019)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1NHa5M-0001dq-IY
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 04:40:53 -0500
Message-ID: <4B1CCD9E.4060402@redhat.com>
Date: Mon, 07 Dec 2009 10:40:46 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH V8 00/18] split out piix specific part	from
	pc emulator
References: <1259905865-25295-1-git-send-email-yamahata@valinux.co.jp>	<4B19181F.1070502@codemonkey.ws>
	<20091205002058.GC3670@valinux.co.jp>
In-Reply-To: <20091205002058.GC3670@valinux.co.jp>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

On 12/05/09 01:20, Isaku Yamahata wrote:
> On Fri, Dec 04, 2009 at 08:09:35AM -0600, Anthony Liguori wrote:
>> Isaku Yamahata wrote:
>>> This is the preparation patch for q35 chipset and PCIE support.
>>> Anthony, any chance to merge? Can you please give me comments?
>>>
>>
>> I'd like to see Michael review the PCI changes and Gerd review the pc
>> changes.
>>
>> I'm uncertain if some of the pc refactoring is the right intermediate
>> solution verses just doing the right thing from a qdev perspective.
>
> However when will the final conversion take place?
> It would take long. Another several months or a year is
> surely worth while for the intermediate solution.
> I've already waited for several months vainly. I think the intermediate
> solution is definitively worth while.

I agree here.  The patches untangle piix emulation and pc emulation. 
This is needed for both q35 support and qdev conversion.  Even though 
these patches don't touch qdev bits much it is still a big step into the 
right direction.

I have some minor nits only (see mails to some individual patches).

cheers,
   Gerd