From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NHata-0002Qv-IJ
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 05:32:46 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NHatV-0002Lr-ML
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 05:32:46 -0500
Received: from [199.232.76.173] (port=52357 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NHatV-0002Lh-ES
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 05:32:41 -0500
Received: from mx1.redhat.com ([209.132.183.28]:61581)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1NHatV-0005vn-07
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 05:32:41 -0500
Received: from int-mx03.intmail.prod.int.phx2.redhat.com
	(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nB7AWeek026206
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 7 Dec 2009 05:32:40 -0500
Message-ID: <4B1CD9C4.4020509@redhat.com>
Date: Mon, 07 Dec 2009 11:32:36 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1259137008-9669-1-git-send-email-kraxel@redhat.com>
	<1259137008-9669-2-git-send-email-kraxel@redhat.com>
	<20091207093716.GA31370@redhat.com>
In-Reply-To: <20091207093716.GA31370@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/2] virtio: enable msi-x for
	console+balloon
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On 12/07/09 10:37, Michael S. Tsirkin wrote:
>
> Sorry, I missed this the first time this was posted, and I see this in
> staging now. Gerd, could you please explain the motivation for this
> patch?
>
> I assumed console/baloon interrupts are not performance critical, so
> would we not be better off using a shared interrupt for these,
> reserving MSI vectors for where performance matters?

The motivation was to move them away from the ioapic, to reduce irq 
sharing of *other* devices which are connected to the ioapic too (i.e. 
usb, e1000, lsi, ...)

I'm aware that these are not performance-critical.  I've even tried to 
use 'vectors=1' because of that.  I expected that would make them use 
MSI-X, but a single IRQ line only.  Didn't work though.  Intentional?

cheers,
   Gerd