From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NHbhP-0005i2-SQ
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 06:24:15 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NHbhL-0005eu-4R
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 06:24:15 -0500
Received: from [199.232.76.173] (port=54066 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NHbhK-0005ep-RC
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 06:24:10 -0500
Received: from mx1.redhat.com ([209.132.183.28]:22545)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1NHbhK-0001Lw-0Z
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 06:24:10 -0500
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nB7BO82r003682
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 7 Dec 2009 06:24:09 -0500
Message-ID: <4B1CE5D2.5080205@redhat.com>
Date: Mon, 07 Dec 2009 12:24:02 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1259137008-9669-1-git-send-email-kraxel@redhat.com>
	<1259137008-9669-2-git-send-email-kraxel@redhat.com>
	<20091207093716.GA31370@redhat.com> <4B1CD9C4.4020509@redhat.com>
	<20091207105950.GA3376@redhat.com>
In-Reply-To: <20091207105950.GA3376@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/2] virtio: enable msi-x for
	console+balloon
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On 12/07/09 11:59, Michael S. Tsirkin wrote:
>> The motivation was to move them away from the ioapic, to reduce irq
>> sharing of *other* devices which are connected to the ioapic too (i.e.
>> usb, e1000, lsi, ...)
>
> Let's convert these to MSI instead?
> This will likely pay off long term,
> e.g. with nested virtualization.

Works only of the real hardware we emulate can do MSI-X too, otherwise 
guests simply wouldn't use it.  I think the only case where this could 
work out is e1000, newer revisions can do MSI-X.  Maybe also the 
upcoming megasas emulation Hannes is working on.

>> I'm aware that these are not performance-critical.  I've even tried to
>> use 'vectors=1' because of that.  I expected that would make them use
>> MSI-X, but a single IRQ line only.  Didn't work though.  Intentional?
>
> So it's even worse, we are using up 2 vectors per device? Ugh ...

Yes.  Three for balloon, but that can easily changed to two.

> no way to distinguish between vq interrupt
> and config change. This last thing is important
> because it allows fastpath injection of MSI
> interrupts directly from kernel without
> notifying qemu to update IRQ field.

Ah, *that* is the reason for the separate config interrupt.  Does the 
in-kernel injection matter for balloon+console?  I'd expect only 
virtio-net needs that when it is configured with vhost?

cheers
   Gerd