From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NHdcm-0004zO-IT for qemu-devel@nongnu.org; Mon, 07 Dec 2009 08:27:36 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NHdcg-0004st-Ov for qemu-devel@nongnu.org; Mon, 07 Dec 2009 08:27:35 -0500 Received: from [199.232.76.173] (port=58097 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NHdcg-0004sQ-ET for qemu-devel@nongnu.org; Mon, 07 Dec 2009 08:27:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45886) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NHdcf-00059Y-SU for qemu-devel@nongnu.org; Mon, 07 Dec 2009 08:27:30 -0500 Message-ID: <4B1D02BC.4050202@redhat.com> Date: Mon, 07 Dec 2009 14:27:24 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1260189773-20728-1-git-send-email-kraxel@redhat.com> <1260189773-20728-6-git-send-email-kraxel@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [FOR 0.12 PATCH v3 05/21] default devices: core code & serial lines. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com On 12/07/09 13:52, Alexander Graf wrote: >> diff --git a/vl.c b/vl.c index 24d5d92..eca4eee 100644 --- a/vl.c >> +++ b/vl.c @@ -271,6 +271,30 @@ uint8_t qemu_uuid[16]; static >> QEMUBootSetHandler *boot_set_handler; static void >> *boot_set_opaque; >> >> +static int default_serial = 1; > > Default variables belong in the machine description IMHO. On S390, we > can't create serial, parallel or vga (or any MMIO/PIO requiring) > devices. See last patch of this series. Moving that into the machine description is certainly worth looking at. For now I'm happy that the #ifdef S390 code for the default virtio console is down to just two lines. cheers Gerd