From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NHdfy-0000UQ-Cs
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 08:30:54 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NHdft-0000Nn-I4
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 08:30:53 -0500
Received: from [199.232.76.173] (port=50422 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NHdft-0000NZ-DP
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 08:30:49 -0500
Received: from mx1.redhat.com ([209.132.183.28]:40389)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1NHdft-0005Tv-6J
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 08:30:49 -0500
Message-ID: <4B1D0381.1050300@redhat.com>
Date: Mon, 07 Dec 2009 14:30:41 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1260189773-20728-1-git-send-email-kraxel@redhat.com>
	<1260189773-20728-6-git-send-email-kraxel@redhat.com>
	<10BCC6E4-80A2-44E0-A740-A8F42E37B17A@suse.de>
In-Reply-To: <10BCC6E4-80A2-44E0-A740-A8F42E37B17A@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [FOR 0.12 PATCH v3 05/21] default devices: core
 code & serial lines.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com

On 12/07/09 13:54, Alexander Graf wrote:
>
> On 07.12.2009, at 13:42, Gerd Hoffmann wrote:
>
>> Qemu creates a default serial line for you in case you didn't specify
>> one on the command line.  Right now this is tied to the '-serial
>> <chardev>' command line switch, which in turn causes trouble if you are
>> creating your serial line via '-device isa-serial,<props>'.

>> +static int default_serial = 1;
>> +
>> +static struct {
>> +    const char *driver;
>> +    int *flag;
>> +} default_list[] = {
>> +    { .driver = "isa-serial",           .flag =&default_serial },
>

> What is the "isa-serial" driver supposed to say here?

Yes.

> Is that the qdev driver name? If so, that's just plain wrong. PPC for example uses the ESCC chip to export its serial port.

Just add the driver name to the list then, so '-device ESCC,...' (or 
however it is named in qdev) will stop conflicting with the 
automagically created -serial port too.

cheers,
   Gerd