From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NHdj9-0004Q6-Ox
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 08:34:11 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NHdj5-0004K1-0l
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 08:34:11 -0500
Received: from [199.232.76.173] (port=58804 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NHdj4-0004JU-MB
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 08:34:06 -0500
Received: from mx1.redhat.com ([209.132.183.28]:48757)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1NHdj4-0005sj-FZ
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 08:34:06 -0500
Message-ID: <4B1D0449.6050706@redhat.com>
Date: Mon, 07 Dec 2009 14:34:01 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1260189773-20728-1-git-send-email-kraxel@redhat.com>
	<1260189773-20728-21-git-send-email-kraxel@redhat.com>
	<30BB7946-B916-4191-B353-EF66240041DC@suse.de>
In-Reply-To: <30BB7946-B916-4191-B353-EF66240041DC@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [FOR 0.12 PATCH v3 20/21] default devices: virtio
	consoles.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com

On 12/07/09 14:07, Alexander Graf wrote:

>> +static int default_virtcon = 1;

> Hm, what does this do? Create both virtio-console-pci and virtio-console-s390 when default_virtcon=1?

No.  Make qemu *not* create a default virtio console in case one was 
added via '-device virtio-console-pci'.

cheers,
   Gerd