From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NHekf-0004Xn-R0
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 09:39:49 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NHekb-0004Pi-1r
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 09:39:49 -0500
Received: from [199.232.76.173] (port=52738 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NHeka-0004PH-Of
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 09:39:44 -0500
Received: from mx1.redhat.com ([209.132.183.28]:19821)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1NHeka-00044Y-KI
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 09:39:44 -0500
Message-ID: <4B1D13AB.8060107@redhat.com>
Date: Mon, 07 Dec 2009 15:39:39 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1260189773-20728-1-git-send-email-kraxel@redhat.com>
	<1260189773-20728-6-git-send-email-kraxel@redhat.com>
	<BB9CE32C-DD2D-406F-8024-1AD9581DB58D@suse.de>
	<4B1D02BC.4050202@redhat.com>
	<DB5FDF72-E6CA-4993-90F4-19FB391379CC@suse.de>
In-Reply-To: <DB5FDF72-E6CA-4993-90F4-19FB391379CC@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [FOR 0.12 PATCH v3 05/21] default devices: core
 code & serial lines.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com

On 12/07/09 15:07, Alexander Graf wrote:
>
> On 07.12.2009, at 14:27, Gerd Hoffmann wrote:
>
>>> Default variables belong in the machine description IMHO. On
>>> S390, we can't create serial, parallel or vga (or any MMIO/PIO
>>> requiring) devices.
>>
>> See last patch of this series.  Moving that into the machine
>> description is certainly worth looking at.  For now I'm happy that
>> the #ifdef S390 code for the default virtio console is down to just
>> two lines.
>
> Would it be that hard to move the list of default devices to the
> machine description? You could probably still keep the default_xxx
> variables in vl.c, but access them from e.g. pc.c.


Hmm?  access from pc.c?  What exactly do you have in mind?


I think we could add flags to QEMUMachine to disable default devices not 
supported anyway, i.e. add no_parallel variable, then in vl.c do

    if (machine->no_parallel)
        default_parallel = 0;

So qemu would stop creating a useless parallel0 chardev which isn't used 
because the machine in question can't support parallel ports anyway.


cheers,
   Gerd