From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NHesB-0005nq-Ou for qemu-devel@nongnu.org; Mon, 07 Dec 2009 09:47:35 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NHes6-0005io-Sb for qemu-devel@nongnu.org; Mon, 07 Dec 2009 09:47:35 -0500 Received: from [199.232.76.173] (port=37886 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NHes6-0005iR-9l for qemu-devel@nongnu.org; Mon, 07 Dec 2009 09:47:30 -0500 Received: from e32.co.us.ibm.com ([32.97.110.150]:49217) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NHes6-00051W-6l for qemu-devel@nongnu.org; Mon, 07 Dec 2009 09:47:30 -0500 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e32.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id nB7Efr22028549 for ; Mon, 7 Dec 2009 07:41:53 -0700 Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id nB7ElHru214506 for ; Mon, 7 Dec 2009 07:47:19 -0700 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id nB7En3tu032527 for ; Mon, 7 Dec 2009 07:49:03 -0700 Message-ID: <4B1D1571.7050906@linux.vnet.ibm.com> Date: Mon, 07 Dec 2009 08:47:13 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <4B1BC4EC.90704@web.de> <4B1CB903.9000900@redhat.com> In-Reply-To: <4B1CB903.9000900@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] kvm: x86: Fix initial kvm_has_msr_star List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Marcelo Tosatti , Jan Kiszka , qemu-devel Avi Kivity wrote: > On 12/06/2009 04:51 PM, Jan Kiszka wrote: >> KVM_GET_MSR_INDEX_LIST returns -E2BIG when the provided space is too >> small for all MSRs. But this is precisely the error we trigger with the >> initial request in order to obtain that size. Do not fail in that case. >> >> This caused a subtle corruption of the guest state as MSR_STAR was not >> properly saved/restored. The corruption became visible with latest kvm >> optimizing the MSR updates. >> > > I applied this to qemu-kvm since it missed 0.12-rc1. I've got it in my tree. It will be a part of 0.12-rc2 and I'll push to master today. Don't know when 0.11.2 will happen but I'll also push it to the stable-0.11 branch. -- Regards, Anthony Liguori