From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NHg6C-0007dS-U6 for qemu-devel@nongnu.org; Mon, 07 Dec 2009 11:06:09 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NHg68-0007b6-3i for qemu-devel@nongnu.org; Mon, 07 Dec 2009 11:06:08 -0500 Received: from [199.232.76.173] (port=38373 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NHg67-0007aw-Di for qemu-devel@nongnu.org; Mon, 07 Dec 2009 11:06:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33899) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NHg67-0005Eu-CO for qemu-devel@nongnu.org; Mon, 07 Dec 2009 11:06:03 -0500 Message-ID: <4B1D27E5.2090207@redhat.com> Date: Mon, 07 Dec 2009 17:05:57 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1260189773-20728-1-git-send-email-kraxel@redhat.com> <1260189773-20728-6-git-send-email-kraxel@redhat.com> <4B1D02BC.4050202@redhat.com> <4B1D13AB.8060107@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [FOR 0.12 PATCH v3 05/21] default devices: core code & serial lines. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com On 12/07/09 16:12, Alexander Graf wrote: > Well I was basically thinking of moving default_list inside the > machine description. That way you can easily choose what default > devices there are available. Doesn't make sense. The list is not about *creating* default devices, but about *not* creating them. > Then make default_serial and friends visible to pc.c and just put the > same code you have now in there. For other machines the default > device list surely looks different. ppc, sparc and x86 serial devices can happily live together in this list without causing any harm. cheers, Gerd