From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NHhZw-0003fb-ID
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 12:40:56 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NHhZr-0003an-Qt
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 12:40:56 -0500
Received: from [199.232.76.173] (port=45719 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NHhZr-0003ad-Mt
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 12:40:51 -0500
Received: from mail-qy0-f194.google.com ([209.85.221.194]:53752)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NHhZs-0006tK-2h
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 12:40:52 -0500
Received: by qyk32 with SMTP id 32so1934542qyk.4
	for <qemu-devel@nongnu.org>; Mon, 07 Dec 2009 09:40:51 -0800 (PST)
Message-ID: <4B1D3E20.2030407@codemonkey.ws>
Date: Mon, 07 Dec 2009 11:40:48 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Permit zero-sized qemu_malloc() & friends
References: <m3skbwxgkp.fsf@crossbow.pond.sub.org>
	<4B1D2462.3070000@codemonkey.ws> <4B1D2696.5080003@redhat.com>
	<4B1D27EE.7060400@codemonkey.ws> <4B1D292D.4010700@redhat.com>
	<4B1D2B54.40402@codemonkey.ws> <4B1D2CC2.7010806@redhat.com>
	<4B1D2E2E.6060907@codemonkey.ws> <4B1D2F38.1040604@redhat.com>
	<4B1D347A.3030102@codemonkey.ws> <4B1D363A.5020200@redhat.com>
	<4B1D36BE.9020801@codemonkey.ws> <4B1D37D2.3010707@redhat.com>
	<4B1D38B1.7040705@codemonkey.ws> <4B1D392C.4070109@redhat.com>
In-Reply-To: <4B1D392C.4070109@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Paul Brook <paul@codesourcery.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

Avi Kivity wrote:
> On 12/07/2009 07:17 PM, Anthony Liguori wrote:
>> Avi Kivity wrote:
>>> I don't understand.  People will develop patches for 0.12 for a 
>>> while as bugs are reported and fixed.
>>
>> What's the exact problem here?
>>
>
> Bug reported against qemu.  Developer develops patch, while testing 
> qemu crashes on unrelated assert(size == 0).

1) Developer develops a patch against 0.12, it works, and they submit it 
to upstream.
2) Upstream crashes because of assert(size==0).
3) Developer is publicly shamed for developing against a release instead 
of a git tree.

The problem is (1), not (2).   Not to mention that we won't allow 
qemu_malloc() uses in upstream anymore which should make (2) impossible.

Regards,

Anthony Liguori