From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NHjJY-0007Xn-3a
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 14:32:08 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NHjJT-0007V2-0y
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 14:32:07 -0500
Received: from [199.232.76.173] (port=38197 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NHjJS-0007Up-QW
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 14:32:02 -0500
Received: from mail-qy0-f194.google.com ([209.85.221.194]:56816)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NHjJS-0002KK-Jk
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 14:32:02 -0500
Received: by qyk32 with SMTP id 32so1981463qyk.4
	for <qemu-devel@nongnu.org>; Mon, 07 Dec 2009 11:32:01 -0800 (PST)
Message-ID: <4B1D582F.9080006@codemonkey.ws>
Date: Mon, 07 Dec 2009 13:31:59 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 06/17] monitor: Convert do_info_status()
	to QObject
References: <1259946695-15784-1-git-send-email-lcapitulino@redhat.com>
	<1259946695-15784-7-git-send-email-lcapitulino@redhat.com>
In-Reply-To: <1259946695-15784-7-git-send-email-lcapitulino@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org

Luiz Capitulino wrote:
> Return a QString with status information.
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  monitor.c |   33 +++++++++++++++++++++++++++------
>  1 files changed, 27 insertions(+), 6 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index 8cedfa9..03f5d7a 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -1865,16 +1865,36 @@ static void do_inject_nmi(Monitor *mon, const QDict *qdict)
>  }
>  #endif
>  
> -static void do_info_status(Monitor *mon)
> +static void do_info_status_print(Monitor *mon, const QObject *data)
>  {
> +    monitor_printf(mon, "VM status: %s\n",
> +                   qstring_get_str(qobject_to_qstring(data)));
> +}
> +
> +/**
> + * do_info_status(): VM status
> + *
> + * Return a QString with status information, which can be:
> + *
> + * - "running"
> + * - "running (single step mode)"
> + * - "paused"
> + */
> +static void do_info_status(Monitor *mon, QObject **ret_data)
> +{
> +    QString *qs;
> +
>      if (vm_running) {
>          if (singlestep) {
> -            monitor_printf(mon, "VM status: running (single step mode)\n");
> +            qs = qstring_from_str("running (single step mode)");
>          } else {
> -            monitor_printf(mon, "VM status: running\n");
> +            qs = qstring_from_str("running");
>          }
> -    } else
> -       monitor_printf(mon, "VM status: paused\n");
> +    } else {
> +       qs = qstring_from_str("paused");
> +    }
> +
> +    *ret_data = QOBJECT(qs);
>  }
>   

Wouldn't this be better as "{'running': true, 'single-step': false}"?

Please send an incremental patch.

Regards,

Anthony Liguori