From: Gerd Hoffmann <kraxel@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix backcompat for hotplug of SCSI controllers
Date: Tue, 08 Dec 2009 11:49:31 +0100 [thread overview]
Message-ID: <4B1E2F3B.7060803@redhat.com> (raw)
In-Reply-To: <4B1D7986.3050608@codemonkey.ws>
On 12/07/09 22:54, Anthony Liguori wrote:
> Daniel P. Berrange wrote:
>> SCSI controllers have no trouble existing without any attached
>> disks. This could be achieved with the (legacy) monitor syntax
>>
>> pci_add pci_addr=auto storage if=scsi
>>
>> This is now denied with
>>
>> scsi requires a backing file/device.
>> failed to add if=scsi
>>
>> There is no need for this denial and it breaks compatability
>> with existing QEMU usage, so remove the check for presence
>> of a drive.
>
> Gerd, care to comment? This bit of code seems pretty intentional:
Looks fine to me. If older qemu versions allow creating disk-less scsi
adapters this way we should keep that behavior for compatibility reasons.
> commit 5b684b5a56e81f6f88234952fe8ed68010c36e19
> Author: Gerd Hoffmann <kraxel@redhat.com>
> Date: Tue Oct 13 13:59:55 2009 +0200
>
> hotplug: fix "pci_add storage if=scsi"
There is no conflict with this bugfix.
cheers,
Gerd
prev parent reply other threads:[~2009-12-08 10:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-07 20:51 [Qemu-devel] [PATCH] Fix backcompat for hotplug of SCSI controllers Daniel P. Berrange
2009-12-07 21:54 ` Anthony Liguori
2009-12-08 10:49 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1E2F3B.7060803@redhat.com \
--to=kraxel@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).