From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NHxdY-0006mi-LE
	for qemu-devel@nongnu.org; Tue, 08 Dec 2009 05:49:44 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NHxdU-0006iB-T4
	for qemu-devel@nongnu.org; Tue, 08 Dec 2009 05:49:44 -0500
Received: from [199.232.76.173] (port=58943 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NHxdU-0006hi-I0
	for qemu-devel@nongnu.org; Tue, 08 Dec 2009 05:49:40 -0500
Received: from mx1.redhat.com ([209.132.183.28]:15199)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1NHxdU-0007kc-4t
	for qemu-devel@nongnu.org; Tue, 08 Dec 2009 05:49:40 -0500
Message-ID: <4B1E2F3B.7060803@redhat.com>
Date: Tue, 08 Dec 2009 11:49:31 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Fix backcompat for hotplug of
	SCSI	controllers
References: <1260219109-14380-1-git-send-email-berrange@redhat.com>
	<4B1D7986.3050608@codemonkey.ws>
In-Reply-To: <4B1D7986.3050608@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

On 12/07/09 22:54, Anthony Liguori wrote:
> Daniel P. Berrange wrote:
>> SCSI controllers have no trouble existing without any attached
>> disks. This could be achieved with the (legacy) monitor syntax
>>
>> pci_add pci_addr=auto storage if=scsi
>>
>> This is now denied with
>>
>> scsi requires a backing file/device.
>> failed to add if=scsi
>>
>> There is no need for this denial and it breaks compatability
>> with existing QEMU usage, so remove the check for presence
>> of a drive.
>
> Gerd, care to comment? This bit of code seems pretty intentional:

Looks fine to me.  If older qemu versions allow creating disk-less scsi 
adapters this way we should keep that behavior for compatibility reasons.

> commit 5b684b5a56e81f6f88234952fe8ed68010c36e19
> Author: Gerd Hoffmann <kraxel@redhat.com>
> Date: Tue Oct 13 13:59:55 2009 +0200
>
> hotplug: fix "pci_add storage if=scsi"

There is no conflict with this bugfix.

cheers,
   Gerd