From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NI8IS-000710-KS for qemu-devel@nongnu.org; Tue, 08 Dec 2009 17:12:40 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NI8IO-0006up-S3 for qemu-devel@nongnu.org; Tue, 08 Dec 2009 17:12:40 -0500 Received: from [199.232.76.173] (port=46101 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NI8IO-0006uY-Ku for qemu-devel@nongnu.org; Tue, 08 Dec 2009 17:12:36 -0500 Received: from mail-gx0-f223.google.com ([209.85.217.223]:42838) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NI8IO-0000C1-6Y for qemu-devel@nongnu.org; Tue, 08 Dec 2009 17:12:36 -0500 Received: by gxk23 with SMTP id 23so3409452gxk.2 for ; Tue, 08 Dec 2009 14:12:33 -0800 (PST) Message-ID: <4B1ECF4C.2080204@codemonkey.ws> Date: Tue, 08 Dec 2009 16:12:28 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] fix rtc-td-hack on host without high-res timers References: <20091208135054.GE7645@redhat.com> In-Reply-To: <20091208135054.GE7645@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: qemu-devel@nongnu.org Gleb Natapov wrote: > On hosts without high-res timers it is impossible to inject rtc interrupt > faster then 1kHz. Windows sometimes configures RTC to generate 1kHz > interrupts, so we can't inject missed interrupts when running on such > hosts. Always injecting an interrupt on REG_C read is also not an option > since Windows wait for REG_C to become zero with interrupt disabled > during boot. This patch uses mixed approach: accelerate timer + inject > up to 1000 interrupts on REG_C read. > > Signed-off-by: Gleb Natapov > Looks good. I'll commit this for -rc2. Regards, Anthony Liguori