From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NIkyT-0004bI-0T
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 10:30:37 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NIkyN-0004TO-Rt
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 10:30:36 -0500
Received: from [199.232.76.173] (port=49930 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NIkyN-0004TC-Kp
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 10:30:31 -0500
Received: from e9.ny.us.ibm.com ([32.97.182.139]:48351)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@linux.vnet.ibm.com>) id 1NIkyN-0001ZR-Uv
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 10:30:32 -0500
Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233])
	by e9.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id nBAFOAlJ015209
	for <qemu-devel@nongnu.org>; Thu, 10 Dec 2009 10:24:10 -0500
Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245])
	by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	nBAFUTLA081746
	for <qemu-devel@nongnu.org>; Thu, 10 Dec 2009 10:30:30 -0500
Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1])
	by d03av06.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP
	id nBAFW6QJ028210
	for <qemu-devel@nongnu.org>; Thu, 10 Dec 2009 08:32:07 -0700
Message-ID: <4B211408.2040205@linux.vnet.ibm.com>
Date: Thu, 10 Dec 2009 09:30:16 -0600
From: Anthony Liguori <aliguori@linux.vnet.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 20/20] VNC: Convert do_info_vnc() to QObject
References: <1260456215-31022-1-git-send-email-lcapitulino@redhat.com>
	<1260456215-31022-21-git-send-email-lcapitulino@redhat.com>
	<Pine.LNX.4.64.0912101825410.2803@linmac.oyster.ru>
In-Reply-To: <Pine.LNX.4.64.0912101825410.2803@linmac.oyster.ru>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

malc wrote:
> On Thu, 10 Dec 2009, Luiz Capitulino wrote:
>
>   
>> Return a QDict with server information. Connected clients are returned
>> as a QList of QDicts.
>>
>> The new functions (vnc_qdict_remote_addr(), vnc_qdict_local_addr() and
>> put_addr_qdict()) are used to insert 'host' and 'service' information
>> in the returned QDict.
>>
>> This patch is big, but I don't see how to split it.
>>
>> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
>>     
> [..snip..]
>
>   
>> +
>> +static int vnc_qdict_local_addr(QDict *qdict, int fd)
>> +{
>> +    struct sockaddr_storage sa;
>> +    socklen_t salen;
>> +
>> +    salen = sizeof(sa);
>> +    if (getsockname(fd, (struct sockaddr*)&sa, &salen) < 0)
>> +        return -1;
>>     
>
> Coding style violation, here and all over the place.
>   

Indeed, please fix.

-- 
Regards,

Anthony Liguori