From: Anthony Liguori <anthony@codemonkey.ws>
To: Yaniv Kaul <ykaul@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Question on QEMU's VNC Server hextile implementation
Date: Sun, 13 Dec 2009 17:53:59 -0600 [thread overview]
Message-ID: <4B257E97.6000904@codemonkey.ws> (raw)
In-Reply-To: <575929515.1599781260738392519.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
Yaniv Kaul wrote:
> According to the RFB protocol, section 6.6.4 (hextile encoding), regarding the 'ForegroundSpecified' bit, it says: 'If this bit is set then the SubrectsColoured bit must be zero.'.
> It doesn't seem QEMU's VNC server does that. In fact, it looks like both bits are set.
> I've verified against a different VNC server, and I didn't see this happening.
> (it may be a Wireshark dissector bug, of course).
>
Yes, this definitely goes against the wording in the specification.
It's also wasting bits on the wire. I'll work up a patch on Monday.
I checked the real vnc client to make sure it handles this combination
and it does. I think the reason the spec forbids this is that a
SubrectsColoured invalidates the foreground color. Having the two is
therefore not a useful combination because the foreground color won't
actually be used for anything.
We do invalidate the foreground color correctly but we're just sending
out useless data so removing it's a good idea. Thanks for catching this!
Regards,
Anthony Liguori
> TIA,
> Y.
>
>
>
prev parent reply other threads:[~2009-12-13 23:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1783738934.1599701260735354287.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-12-13 21:06 ` [Qemu-devel] Question on QEMU's VNC Server hextile implementation Yaniv Kaul
2009-12-13 23:53 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B257E97.6000904@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=ykaul@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).