From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NK2Ki-0003pg-Ez for qemu-devel@nongnu.org; Sun, 13 Dec 2009 23:14:52 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NK2Kh-0003pU-Dj for qemu-devel@nongnu.org; Sun, 13 Dec 2009 23:14:51 -0500 Received: from [199.232.76.173] (port=41398 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NK2Kh-0003pR-8F for qemu-devel@nongnu.org; Sun, 13 Dec 2009 23:14:51 -0500 Received: from are.twiddle.net ([75.149.56.221]:42780) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NK2Kg-00017L-PM for qemu-devel@nongnu.org; Sun, 13 Dec 2009 23:14:51 -0500 Received: from stone.twiddle.home (stone.twiddle.home [172.31.0.16]) by are.twiddle.net (Postfix) with ESMTPSA id DC3AC304 for ; Sun, 13 Dec 2009 20:14:48 -0800 (PST) Message-ID: <4B25BBB8.5070807@twiddle.net> Date: Sun, 13 Dec 2009 20:14:48 -0800 From: Richard Henderson MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------090307000804050007030700" Subject: [Qemu-devel] [patch] linux-user: problem with mmap_find_vma List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is a multi-part message in MIME format. --------------090307000804050007030700 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit With host x86_64 target alpha, a trivial recompile started producing "MMU faults". Eventually, I determined that adding "-B 0x100000000" was enough to produce the fault with the original working executable. I expect, but have not verified, that a similar failure can be elicited with any 64-bit host and any target using such a large explicit base. The cause is that the default address used by mmap_find_vma may not be inside the area defined for use by the guest by GUEST_BASE. Certainly this patch fixes the failure I was seeing. I cannot see though all the macro ugliness to understand what happens when GUEST_BASE is not in use to know what needs happening there. Please feel free to edit the ??? comment to match reality. r~ --------------090307000804050007030700 Content-Type: text/plain; name="commit-find-vma" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="commit-find-vma" Y29tbWl0IGE4NWI0OTllYWJlNWE3MWJiMDIzMDVjMjg1NmMxMzY1OTAyNzZlZGYKQXV0aG9y OiBSaWNoYXJkIEhlbmRlcnNvbiA8cnRoQHR3aWRkbGUubmV0PgpEYXRlOiAgIFN1biBEZWMg MTMgMjA6MDA6MzkgMjAwOSAtMDgwMAoKICAgIGxpbnV4LXVzZXI6IEFkanVzdCBtbWFwX2Zp bmRfdm1hIGZvciBndWVzdF9iYXNlLgogICAgCiAgICBUaGUgZGVmaW5pdGlvbiBvZiBtbWFw X2ZpbmRfdm1hIHJlcXVpcmVzIGd1ZXN0IGFkZHJlc3NlcyBhcyBpbnB1dAogICAgdG8gdGhl IFNUQVJUIHBhcmFtZXRlci4gIEhvd2V2ZXIsIHdoZW4gU1RBUlQ9PTAgaS5lLiBubyBwcmVm ZXJyZWQKICAgIGFkZHJlc3MsIHdlIHVzZSBhIHZhbHVlIHByZS1kZWZpbmVkIHZhbHVlIHdo aWNoIG1heSBub3QgYmUgd2l0aGluCiAgICB0aGUgYXJlYSBkZWZpbmVkIGJ5IEdVRVNUX0JB U0UuICBNYWtlIHN1cmUgYW5kIGFkanVzdCB0aGF0IHZhbHVlCiAgICB2aWEgZzJoIGJlZm9y ZSB1c2luZyBpdC4KCmRpZmYgLS1naXQgYS9saW51eC11c2VyL21tYXAuYyBiL2xpbnV4LXVz ZXIvbW1hcC5jCmluZGV4IDE0NGZiN2MuLjdlMDRjMjMgMTAwNjQ0Ci0tLSBhL2xpbnV4LXVz ZXIvbW1hcC5jCisrKyBiL2xpbnV4LXVzZXIvbW1hcC5jCkBAIC0yNjYsMTEgKzI2NiwxMyBA QCBzdGF0aWMgaW50IG1tYXBfZnJhZyhhYmlfdWxvbmcgcmVhbF9zdGFydCwKIAogI2lmIGRl ZmluZWQoX19DWUdXSU5fXykKIC8qIEN5Z3dpbiBkb2Vzbid0IGhhdmUgYSB3aG9sZSBsb3Qg b2YgYWRkcmVzcyBzcGFjZS4gICovCi1zdGF0aWMgYWJpX3Vsb25nIG1tYXBfbmV4dF9zdGFy dCA9IDB4MTgwMDAwMDA7CisjZGVmaW5lIE1NQVBfRklSU1RfU1RBUlQgMHgxODAwMDAwMAog I2Vsc2UKLXN0YXRpYyBhYmlfdWxvbmcgbW1hcF9uZXh0X3N0YXJ0ID0gMHg0MDAwMDAwMDsK KyNkZWZpbmUgTU1BUF9GSVJTVF9TVEFSVCAweDQwMDAwMDAwCiAjZW5kaWYKIAorc3RhdGlj IGFiaV91bG9uZyBtbWFwX25leHRfc3RhcnQ7CisKIHVuc2lnbmVkIGxvbmcgbGFzdF9icms7 CiAKIC8qCkBAIC0yODgsOCArMjkwLDE5IEBAIGFiaV91bG9uZyBtbWFwX2ZpbmRfdm1hKGFi aV91bG9uZyBzdGFydCwgYWJpX3Vsb25nIHNpemUpCiAgICAgc3RhcnQgJj0gcWVtdV9ob3N0 X3BhZ2VfbWFzazsKIAogICAgIC8qIElmICdzdGFydCcgPT0gMCwgdGhlbiBhIGRlZmF1bHQg c3RhcnQgYWRkcmVzcyBpcyB1c2VkLiAqLwotICAgIGlmIChzdGFydCA9PSAwKQorICAgIGlm IChzdGFydCA9PSAwKSB7CiAgICAgICAgIHN0YXJ0ID0gbW1hcF9uZXh0X3N0YXJ0OworICAg ICAgICBpZiAoc3RhcnQgPT0gMCkgeworI2lmZGVmIENPTkZJR19VU0VfR1VFU1RfQkFTRQor ICAgICAgICAgICAgbW1hcF9uZXh0X3N0YXJ0ID0gc3RhcnQgPSAoYWJpX3Vsb25nKSBnMmgo TU1BUF9GSVJTVF9TVEFSVCk7CisjZWxzZQorICAgICAgICAgICAgLyogPz8/IFdoYXQgc29y dCBvZiBob3N0LWd1ZXN0IHJlbWFwcGluZyBkbyB3ZSB1c2UgZm9yCisgICAgICAgICAgICAg ICB3aGVuIEdVRVNUX0JBU0UgaXMgbm90IGluIHVzZT8gIFByZXN1bWFibHkgd2UgY2FuCisg ICAgICAgICAgICAgICBzaW1wbHkgbWFwIGF0IGFueSBhZGRyZXNzIHdlIGNob29zZS4gICov CisgICAgICAgICAgICBtbWFwX25leHRfc3RhcnQgPSBzdGFydCA9IE1NQVBfRklSU1RfU1RB UlQ7CisjZW5kaWYKKyAgICAgICAgfQorICAgIH0KIAogICAgIGFkZHIgPSBzdGFydDsKIAo= --------------090307000804050007030700--