From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NK7Qx-0006GT-Jz for qemu-devel@nongnu.org; Mon, 14 Dec 2009 04:41:39 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NK7Qs-0006Fg-0N for qemu-devel@nongnu.org; Mon, 14 Dec 2009 04:41:39 -0500 Received: from [199.232.76.173] (port=47741 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NK7Qr-0006Fd-Ow for qemu-devel@nongnu.org; Mon, 14 Dec 2009 04:41:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50242) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NK7Qr-00089A-Da for qemu-devel@nongnu.org; Mon, 14 Dec 2009 04:41:33 -0500 Message-ID: <4B260846.9020503@redhat.com> Date: Mon, 14 Dec 2009 10:41:26 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <20091213204341.GA25823@redhat.com> In-Reply-To: <20091213204341.GA25823@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH RFC] virtio: add features qdev property List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On 12/13/09 21:43, Michael S. Tsirkin wrote: > Add features property to virtio. This makes it > possible to e.g. define machine without indirect > buffer support, which is required for 0.10 > compatibility. or without hardware checksum > support, which is required for 0.11 compatibility. I'd suggest to add flags for the individual features to the drivers which actually use it instead, so you'll have -device virtio-net-pci,hw-checksum=0 and -device virtio-blk-pci,indirect-buffers=0 cheers, Gerd