From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NKC5L-0000PT-0u
	for qemu-devel@nongnu.org; Mon, 14 Dec 2009 09:39:39 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NKC5F-0000N7-MG
	for qemu-devel@nongnu.org; Mon, 14 Dec 2009 09:39:38 -0500
Received: from [199.232.76.173] (port=50995 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NKC5F-0000N4-HT
	for qemu-devel@nongnu.org; Mon, 14 Dec 2009 09:39:33 -0500
Received: from mail-yx0-f188.google.com ([209.85.210.188]:37754)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NKC5F-0004JZ-Gb
	for qemu-devel@nongnu.org; Mon, 14 Dec 2009 09:39:33 -0500
Received: by yxe26 with SMTP id 26so2935072yxe.4
	for <qemu-devel@nongnu.org>; Mon, 14 Dec 2009 06:39:32 -0800 (PST)
Message-ID: <4B264E22.6000503@codemonkey.ws>
Date: Mon, 14 Dec 2009 08:39:30 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Check rom_load_all() return value.
References: <1260788938-20864-1-git-send-email-kraxel@redhat.com>
In-Reply-To: <1260788938-20864-1-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann wrote:
> ... otherwise we'll continue without the bios loaded in case the
> option roms don't fit.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  vl.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index c0d98f5..1682808 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -6031,7 +6031,10 @@ int main(int argc, char **argv, char **envp)
>  
>      qdev_machine_creation_done();
>  
> -    rom_load_all();
> +    if (rom_load_all() != 0) {
> +        fprintf(stderr, "rom loading failed\n");
> +        exit(1);
> +    }
>   

Failing to load option roms shouldn't be treated as a critical failure.  
The BIOS has dedicated space so no amount of option roms should prevent 
the BIOS from loading.

So I think we may need to tweak rom_load_all() a bit to be more 
intelligent about handling this.

Regards,

Anthony Liguori