* [Qemu-devel] [PATCH] Check rom_load_all() return value.
@ 2009-12-14 11:08 Gerd Hoffmann
2009-12-14 14:39 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Gerd Hoffmann @ 2009-12-14 11:08 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
... otherwise we'll continue without the bios loaded in case the
option roms don't fit.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
vl.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/vl.c b/vl.c
index c0d98f5..1682808 100644
--- a/vl.c
+++ b/vl.c
@@ -6031,7 +6031,10 @@ int main(int argc, char **argv, char **envp)
qdev_machine_creation_done();
- rom_load_all();
+ if (rom_load_all() != 0) {
+ fprintf(stderr, "rom loading failed\n");
+ exit(1);
+ }
qemu_system_reset();
if (loadvm) {
--
1.6.5.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] Check rom_load_all() return value.
2009-12-14 11:08 [Qemu-devel] [PATCH] Check rom_load_all() return value Gerd Hoffmann
@ 2009-12-14 14:39 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2009-12-14 14:39 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
Gerd Hoffmann wrote:
> ... otherwise we'll continue without the bios loaded in case the
> option roms don't fit.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> vl.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index c0d98f5..1682808 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -6031,7 +6031,10 @@ int main(int argc, char **argv, char **envp)
>
> qdev_machine_creation_done();
>
> - rom_load_all();
> + if (rom_load_all() != 0) {
> + fprintf(stderr, "rom loading failed\n");
> + exit(1);
> + }
>
Failing to load option roms shouldn't be treated as a critical failure.
The BIOS has dedicated space so no amount of option roms should prevent
the BIOS from loading.
So I think we may need to tweak rom_load_all() a bit to be more
intelligent about handling this.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-14 14:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-14 11:08 [Qemu-devel] [PATCH] Check rom_load_all() return value Gerd Hoffmann
2009-12-14 14:39 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).