From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NKCLx-00051h-SN
	for qemu-devel@nongnu.org; Mon, 14 Dec 2009 09:56:49 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NKCLs-0004uz-VF
	for qemu-devel@nongnu.org; Mon, 14 Dec 2009 09:56:49 -0500
Received: from [199.232.76.173] (port=42319 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NKCLs-0004uY-LW
	for qemu-devel@nongnu.org; Mon, 14 Dec 2009 09:56:44 -0500
Received: from mx1.redhat.com ([209.132.183.28]:8203)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1NKCLs-0006ek-BV
	for qemu-devel@nongnu.org; Mon, 14 Dec 2009 09:56:44 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nBEEuhS7014736
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 14 Dec 2009 09:56:43 -0500
Message-ID: <4B265226.8020700@redhat.com>
Date: Mon, 14 Dec 2009 15:56:38 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH RFC] virtio: add features qdev property
References: <20091213204341.GA25823@redhat.com>
	<4B260846.9020503@redhat.com>	<20091214094255.GA32140@redhat.com>
	<4B261269.7080801@redhat.com>	<20091214111046.GB32355@redhat.com>
	<4B262379.1060009@redhat.com>
	<m3y6l51y50.fsf@crossbow.pond.sub.org>
In-Reply-To: <m3y6l51y50.fsf@crossbow.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

On 12/14/09 14:30, Markus Armbruster wrote:
>> Then the property parser would accepts strings such as 'bit1|bit2' and
>> you can have
>>
>>    -device 'virtio-blk-pci,disable=blk-identify|ring-indirect'
>>
>> The driver will just do 'vdev->host_features&= ~disable'.
>
> Use of '|' in option argument syntax is user-hostile, because it
> requires quoting in the shell.  What about '+'?

I don't care that much.  I've picked '|' because it is 'or' in many 
programming languanges and thus sort of intuitive (at least to me). 
Using '+' is fine with me too.

cheers,
   Gerd