From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NKUQx-0001jv-DB
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 05:15:11 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NKUQq-0001h5-Vt
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 05:15:09 -0500
Received: from [199.232.76.173] (port=57971 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NKUQq-0001gk-NB
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 05:15:04 -0500
Received: from mx1.redhat.com ([209.132.183.28]:51145)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1NKUQp-0005wr-MK
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 05:15:04 -0500
Message-ID: <4B276197.1080606@redhat.com>
Date: Tue, 15 Dec 2009 11:14:47 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: Proper support for PCI-based option rom loading (was Re:
	[Qemu-devel] Re: qdev property bug?)
References: <4B264AF1.6060802@codemonkey.ws>
	<7FB8DD1225E54176BCAF5523B6AEA89B@FSCPC>
	<4B26931E.4000101@codemonkey.ws> <20091214194210.GB6150@redhat.com>
	<4B269933.3010906@codemonkey.ws> <20091214202019.GF6150@redhat.com>
	<4B26A0DE.5000304@redhat.com> <20091214203428.GI6150@redhat.com>
	<20091214203603.GJ6150@redhat.com> <4B26A3B2.2030006@codemonkey.ws>
	<20091214205141.GC6398@redhat.com>
	<4B26F678.4010603@codemonkey.ws> <4B27541F.9020603@redhat.com>
In-Reply-To: <4B27541F.9020603@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, glommer@redhat.com, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Kevin O'Connor <kevin@koconnor.net>, Sebastian Herbszt <herbszt@gmx.de>

   Hi,

> We could also add a "romfile" property to the pci bus and do everything
> (except setting the default filename) in generic pci code.

Patch attached (incremental to yours).

> I'm more worried about the CONFIG_OPTIONROMS_DEPLOYED patches for
> seabios, although I don't fully understand what they are doing. There
> are non-pci option roms (linuxboot, multiboot, extboot) which qemu will
> continue to deploy the way roms are deployed today.

-kernel didn't work on a quick test.

cheers,
   Gerd