From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NKYDp-0007Gv-WA
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 09:17:54 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NKYDk-0007Fg-Er
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 09:17:52 -0500
Received: from [199.232.76.173] (port=55019 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NKYDi-0007FT-Ne
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 09:17:46 -0500
Received: from david.siemens.de ([192.35.17.14]:15845)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <jan.kiszka@siemens.com>) id 1NKYDi-0008Vu-1D
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 09:17:46 -0500
Message-ID: <4B279A85.6030009@siemens.com>
Date: Tue, 15 Dec 2009 15:17:41 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1260824004-2941-1-git-send-email-lcapitulino@redhat.com>	<1260824004-2941-5-git-send-email-lcapitulino@redhat.com>	<m3vdg8pnvs.fsf@crossbow.pond.sub.org>	<m3eimwpnow.fsf@crossbow.pond.sub.org>
	<20091215100810.3ba932a5@doriath>
In-Reply-To: <20091215100810.3ba932a5@doriath>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 4/5] monitor: Avoid readline functions in
	QMP
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

Luiz Capitulino wrote:
> On Tue, 15 Dec 2009 10:54:23 +0100
> Markus Armbruster <armbru@redhat.com> wrote:
> 
>> Markus Armbruster <armbru@redhat.com> writes:
>>
>>> Luiz Capitulino <lcapitulino@redhat.com> writes:
>>>
>>>> The monitor_read_command() function is readline specific
>>>> and should only be used when readline is available.
>>>>
>>>> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
>>> I figure this bug breaks password entry (VNC and block) on non-readline
>>> monitors.  Suspect commit cde76ee1.
> 
>  I can only assume that it didn't matter until now.
> 
>> PS: Subject is wrong.  gdbserver_start() creates a monitor with
>> MONITOR_USE_READLINE off, so it's not just QMP.
> 
>  Ditto.
> 

Right. monitor_read_password was never supposed to be used on monitors
that have not readline state and is reported as error by
monitor_read_password. So far the only monitor that was lacking such
state was the gdbserver, now we also have QMP. The latter handles this
separately, the former should still fail loudly when such commands are
issued.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux