From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NKciQ-0004UE-Bz
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 14:05:46 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NKciL-0004Ir-KE
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 14:05:45 -0500
Received: from [199.232.76.173] (port=58260 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NKciL-0004Ii-GX
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 14:05:41 -0500
Received: from mail-yw0-f171.google.com ([209.85.211.171]:61148)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NKciK-0005p1-Tg
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 14:05:41 -0500
Received: by ywh1 with SMTP id 1so187993ywh.18
	for <qemu-devel@nongnu.org>; Tue, 15 Dec 2009 11:05:40 -0800 (PST)
Message-ID: <4B27DE01.5000003@codemonkey.ws>
Date: Tue, 15 Dec 2009 13:05:37 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: Proper support for PCI-based option rom loading (was Re:
	[Qemu-devel] Re: qdev property bug?)
References: <4B26931E.4000101@codemonkey.ws> <20091214194210.GB6150@redhat.com>
	<4B269933.3010906@codemonkey.ws> <20091214202019.GF6150@redhat.com>
	<4B26A0DE.5000304@redhat.com> <20091214203428.GI6150@redhat.com>
	<20091214203603.GJ6150@redhat.com> <4B26A3B2.2030006@codemonkey.ws>
	<20091214205141.GC6398@redhat.com> <4B26F678.4010603@codemonkey.ws>
	<20091215105130.GA11525@redhat.com>
In-Reply-To: <20091215105130.GA11525@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: glommer@redhat.com, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Kevin O'Connor <kevin@koconnor.net>, Gerd Hoffmann <kraxel@redhat.com>, Sebastian Herbszt <herbszt@gmx.de>

Michael S. Tsirkin wrote:
> From a quick overview, I see register memory but no unregister?
>   

There's no cpu_unregister_physical_memory() in qemu.  Devices can 
unregister an io memory type but this is not io memory, this is ram.

We should qemu_ram_free() though.

Regards,

Anthony Liguori