From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NKfOl-0005QM-GB
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 16:57:39 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NKfOg-0005MI-Gd
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 16:57:38 -0500
Received: from [199.232.76.173] (port=39171 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NKfOg-0005MA-7F
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 16:57:34 -0500
Received: from mail-yx0-f188.google.com ([209.85.210.188]:38774)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NKfOg-0005cX-3l
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 16:57:34 -0500
Received: by yxe26 with SMTP id 26so376423yxe.4
	for <qemu-devel@nongnu.org>; Tue, 15 Dec 2009 13:57:33 -0800 (PST)
Message-ID: <4B28064A.1070501@codemonkey.ws>
Date: Tue, 15 Dec 2009 15:57:30 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: Proper support for PCI-based option rom loading (was Re:
	[Qemu-devel] Re: qdev property bug?)
References: <4B26A0DE.5000304@redhat.com> <20091214203428.GI6150@redhat.com>
	<20091214203603.GJ6150@redhat.com> <4B26A3B2.2030006@codemonkey.ws>
	<20091214205141.GC6398@redhat.com>
	<4B26F678.4010603@codemonkey.ws> <4B27541F.9020603@redhat.com>
	<4B27E1C2.5090506@codemonkey.ws>
	<20091215211900.GG26712@redhat.com>
	<4B280374.5010604@codemonkey.ws>
	<20091215215244.GI26712@redhat.com>
In-Reply-To: <20091215215244.GI26712@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: glommer@redhat.com, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Kevin O'Connor <kevin@koconnor.net>, Gerd Hoffmann <kraxel@redhat.com>, Sebastian Herbszt <herbszt@gmx.de>

Michael S. Tsirkin wrote:
>> Heh, this is going to be really broken with my patches :-)
>>
>> We're during qemu_ram_alloc() and we currently don't have a means to  
>> associate ram with anything meaningful.  This means that if you hot plug  
>> on two ends in different orders (even with fixed slots), the returned  
>> qemu_ram_alloc() pointers will be different for the same device.  This  
>> means when you did the live migration of the rom contents, you'd get the  
>> wrong roms in the wrong places.
>>
>> I think we need to improve how we do qemu_ram_alloc() such that we can  
>> associate some meaningful context with each allocated chunk that we can  
>> migrate with the chunk of ram.
>>
>> Regards,
>>
>> Anthony Liguori
>>     
>
> Hmm. You think all this is 0.12 material?
>   
I think it's stable-0.12 material because it's badly broken right now 
but it's clearly not a candidate for 0.12.0 as it still doesn't work 
reliably.

I'm going to pull in Gerd's fix for 0.12.0.

Regards,

Anthony Liguori