From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NKhxW-000633-L5 for qemu-devel@nongnu.org; Tue, 15 Dec 2009 19:41:42 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NKhxR-000623-Hf for qemu-devel@nongnu.org; Tue, 15 Dec 2009 19:41:41 -0500 Received: from [199.232.76.173] (port=39989 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NKhxR-000620-Bt for qemu-devel@nongnu.org; Tue, 15 Dec 2009 19:41:37 -0500 Received: from mail-yx0-f188.google.com ([209.85.210.188]:61788) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NKhxR-0001RH-42 for qemu-devel@nongnu.org; Tue, 15 Dec 2009 19:41:37 -0500 Received: by yxe26 with SMTP id 26so503926yxe.4 for ; Tue, 15 Dec 2009 16:41:36 -0800 (PST) Message-ID: <4B282CBD.9000707@codemonkey.ws> Date: Tue, 15 Dec 2009 18:41:33 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [SeaBIOS] Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?) References: <4B26931E.4000101@codemonkey.ws> <20091214203603.GJ6150@redhat.com> <4B26A3B2.2030006@codemonkey.ws> <20091214205141.GC6398@redhat.com> <4B26F678.4010603@codemonkey.ws> <20091215043454.GD22611@morn.localdomain> <4B278BE9.3010900@codemonkey.ws> <4B279B24.1090004@codemonkey.ws> <4B279E47.80109@redhat.com> <4B27C8F7.8030608@codemonkey.ws> <28396b010912151554p15e27376lf2279f9811eac2cf@mail.gmail.com> In-Reply-To: <28396b010912151554p15e27376lf2279f9811eac2cf@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin OConnor Cc: seabios@seabios.org, Avi Kivity , qemu-devel@nongnu.org Kevin OConnor wrote: > On Tue, Dec 15, 2009 at 12:35 PM, Anthony Liguori > > wrote: > > Avi Kivity wrote: > > bochs bios required all 128kB, so this is probably a leftover. > > > This is apparently well defined in the PIIX spec. There is a bit > of a difference between the lower half and upper half of the BIOS > region though and I expect this is part of what the problem is. > FYI, the following patch works. Surprisingly, we only need to > restore the 0xe8000..0xe8fff region. Still trying to understand > what's happening. > > > SeaBIOS is currently using over 64K of space. So, it is extending > into the e-segment > and thus needs to have the e-segment copied properly (I missed that in my > earlier email). Okay. So I assume this is something that SeaBIOS needs to do? I've been trying to understand the origin of: // Need to copy optionroms to work around qemu implementation What is it that we're doing wrong in the qemu implementation? If it's the lack of PCI option loading, then I guess we're okay post my changes provided that SeaBIOS can take care of what it needs in the e-segment. Regards, Anthony Liguori