From: Jan Kiszka <jan.kiszka@web.de>
To: TeLeMan <geleman@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [FOR 0.12][PATCH] target-i386: Fix evaluation of DR7 register
Date: Wed, 16 Dec 2009 01:41:50 +0100 [thread overview]
Message-ID: <4B282CCE.1050609@web.de> (raw)
In-Reply-To: <a38b25540912151628j4ac89851u22fed158c859af98@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 716 bytes --]
TeLeMan wrote:
>> Now to the content: env already equals single_cpu_env, so there is no
>> need in writing it back. That's because break/watchpoints are triggered
>> synchronously over the context in which they may raise an exception as
>> result.
> env in op_help.c is asm(AREG0) not single_cpu_env.
Which makes no difference due to the synchronous characteristics. The
point where env and single_cpu_env diverges while a vcpu is running is
the beginning of a bug.
> Did you test your codes?
I'm using it, including SMP.
There is still a bug, but it's unrelated to the context. It's related to
watchpoints triggering in helper function instead of generated code.
Will fix that later.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
prev parent reply other threads:[~2009-12-16 0:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-14 11:26 [Qemu-devel] [FOR 0.12][PATCH] target-i386: Fix evaluation of DR7 register Jan Kiszka
2009-12-15 2:07 ` TeLeMan
2009-12-15 23:21 ` [Qemu-devel] " Jan Kiszka
2009-12-16 0:28 ` TeLeMan
2009-12-16 0:41 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B282CCE.1050609@web.de \
--to=jan.kiszka@web.de \
--cc=aliguori@us.ibm.com \
--cc=geleman@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).