From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NKhxp-0006C9-Um for qemu-devel@nongnu.org; Tue, 15 Dec 2009 19:42:01 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NKhxl-00069V-Ar for qemu-devel@nongnu.org; Tue, 15 Dec 2009 19:42:01 -0500 Received: from [199.232.76.173] (port=39992 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NKhxl-00069O-5m for qemu-devel@nongnu.org; Tue, 15 Dec 2009 19:41:57 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]:60520) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NKhxk-0001S1-Jl for qemu-devel@nongnu.org; Tue, 15 Dec 2009 19:41:56 -0500 Message-ID: <4B282CCE.1050609@web.de> Date: Wed, 16 Dec 2009 01:41:50 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <4B2620E3.2050604@siemens.com> <4B2819E2.7050603@web.de> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig2BAC6C6EBFB7F08CC6ED7230" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [FOR 0.12][PATCH] target-i386: Fix evaluation of DR7 register List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: TeLeMan Cc: Anthony Liguori , qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2BAC6C6EBFB7F08CC6ED7230 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable TeLeMan wrote: >> Now to the content: env already equals single_cpu_env, so there is no >> need in writing it back. That's because break/watchpoints are triggere= d >> synchronously over the context in which they may raise an exception as= >> result. > env in op_help.c is asm(AREG0) not single_cpu_env. Which makes no difference due to the synchronous characteristics. The point where env and single_cpu_env diverges while a vcpu is running is the beginning of a bug. > Did you test your codes? I'm using it, including SMP. There is still a bug, but it's unrelated to the context. It's related to watchpoints triggering in helper function instead of generated code. Will fix that later. Jan --------------enig2BAC6C6EBFB7F08CC6ED7230 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAksoLNIACgkQitSsb3rl5xSAdwCfUi8rvHvbh5p/5dMFcvxAV5dw NF8An0pfG+Qy/QR4kv8zN9ByQghhkz3K =0+D5 -----END PGP SIGNATURE----- --------------enig2BAC6C6EBFB7F08CC6ED7230--