From: Gerd Hoffmann <kraxel@redhat.com>
To: Wolfgang Mauerer <wolfgang.mauerer@siemens.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH, RFC] Allow adding empty SCSI controllers
Date: Wed, 16 Dec 2009 12:54:56 +0100 [thread overview]
Message-ID: <4B28CA90.8050803@redhat.com> (raw)
In-Reply-To: <4B27C7B1.9030609@siemens.com>
On 12/15/09 18:30, Wolfgang Mauerer wrote:
> Hi Gerd,
>
> in commit 5b684b5a56e81f6f, you introduced an explicit check
> to prevent adding SCSI controllers without attached disks
> to the system.
There was a patch from Daniel removing that check, isn't that one merged
meanwhile? Hmm, looks like it isn't.
Your patch does more than just killing the check, especially the chunk
in lsi53c895a.c is clearly wrong. I'd prefer Daniels patch being merged
instead.
> Is there any other method to introduce
> disk-less controllers into the system?
device_add lsi,id=<hba-name>,addr=<slot.func>
adding disks then:
drive_add unused if=none,id=<disk-name>,file=...
device_add scsi-disk,drive=<disk-name>,bus=<hba-name>.0,scsi-id=<nr>
Note that this is the only way you can expect to work reliable with more
than one scsi adapter being present in the system.
cheers,
Gerd
next prev parent reply other threads:[~2009-12-16 11:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 17:30 [Qemu-devel] [PATCH, RFC] Allow adding empty SCSI controllers Wolfgang Mauerer
2009-12-16 11:54 ` Gerd Hoffmann [this message]
2009-12-16 14:34 ` [Qemu-devel] " Wolfgang Mauerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B28CA90.8050803@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wolfgang.mauerer@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).