From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NKsUV-0002lt-15
	for qemu-devel@nongnu.org; Wed, 16 Dec 2009 06:56:27 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NKsUP-0002gW-N4
	for qemu-devel@nongnu.org; Wed, 16 Dec 2009 06:56:25 -0500
Received: from [199.232.76.173] (port=35937 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NKsUP-0002gC-EW
	for qemu-devel@nongnu.org; Wed, 16 Dec 2009 06:56:21 -0500
Received: from mx1.redhat.com ([209.132.183.28]:14277)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1NKsUP-0007bV-1b
	for qemu-devel@nongnu.org; Wed, 16 Dec 2009 06:56:21 -0500
Message-ID: <4B28CA90.8050803@redhat.com>
Date: Wed, 16 Dec 2009 12:54:56 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <4B27C7B1.9030609@siemens.com>
In-Reply-To: <4B27C7B1.9030609@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH, RFC] Allow adding empty SCSI controllers
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wolfgang Mauerer <wolfgang.mauerer@siemens.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 12/15/09 18:30, Wolfgang Mauerer wrote:
> Hi Gerd,
>
> in commit 5b684b5a56e81f6f, you introduced an explicit check
> to prevent adding SCSI controllers without attached disks
> to the system.

There was a patch from Daniel removing that check, isn't that one merged 
meanwhile?  Hmm, looks like it isn't.

Your patch does more than just killing the check, especially the chunk 
in lsi53c895a.c is clearly wrong.  I'd prefer Daniels patch being merged 
instead.

> Is there any other method to introduce
> disk-less controllers into the system?

device_add lsi,id=<hba-name>,addr=<slot.func>

adding disks then:

drive_add unused if=none,id=<disk-name>,file=...
device_add scsi-disk,drive=<disk-name>,bus=<hba-name>.0,scsi-id=<nr>

Note that this is the only way you can expect to work reliable with more 
than one scsi adapter being present in the system.

cheers,
   Gerd