From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NKtwv-0002Yz-Qu for qemu-devel@nongnu.org; Wed, 16 Dec 2009 08:29:53 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NKtwq-0002Wj-Uw for qemu-devel@nongnu.org; Wed, 16 Dec 2009 08:29:53 -0500 Received: from [199.232.76.173] (port=52034 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NKtwq-0002Wb-Ph for qemu-devel@nongnu.org; Wed, 16 Dec 2009 08:29:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29309) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NKtwq-0002Ox-Bk for qemu-devel@nongnu.org; Wed, 16 Dec 2009 08:29:48 -0500 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nBGDTlkF031708 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 16 Dec 2009 08:29:47 -0500 Message-ID: <4B28E0C7.3010605@redhat.com> Date: Wed, 16 Dec 2009 14:29:43 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] fdc: fix drive property handling. References: <1260889756-26864-1-git-send-email-kraxel@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org On 12/16/09 11:03, Markus Armbruster wrote: > This fixes "-global isa-fdc,driveB=DRIVE-ID" for me, but problems > remain: > > * -drive if=none,id=fd,file=fd.img -global isa-fdc.driveA=fd > > dev: isa-fdc, id "" > dev-prop: driveA = floppy0 > dev-prop: driveB = > isa irq 6 Patch is on the list. > * -drive if=none,id=fd,file=fd.img -global isa-fdc.driveA=fd,driveB=fd Oh, -global works like -set, i.e. you can't set multiple properties in one go. Should be '-global isa-fdc.driveA=fd -global isa-fdc.driveB=fd'. The error reporting is *ahem*, well, not perfect. Patch is on the list. cheers, Gerd