From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NKuun-00038r-EI
	for qemu-devel@nongnu.org; Wed, 16 Dec 2009 09:31:45 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NKuui-000370-2n
	for qemu-devel@nongnu.org; Wed, 16 Dec 2009 09:31:44 -0500
Received: from [199.232.76.173] (port=56160 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NKuug-00035u-R9
	for qemu-devel@nongnu.org; Wed, 16 Dec 2009 09:31:39 -0500
Received: from lizzard.sbs.de ([194.138.37.39]:17084)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <wolfgang.mauerer@siemens.com>) id 1NKuug-0002Gx-Cg
	for qemu-devel@nongnu.org; Wed, 16 Dec 2009 09:31:38 -0500
Message-ID: <4B28EFDA.2010301@siemens.com>
Date: Wed, 16 Dec 2009 15:34:02 +0100
From: Wolfgang Mauerer <wolfgang.mauerer@siemens.com>
MIME-Version: 1.0
References: <4B27C7B1.9030609@siemens.com> <4B28CA90.8050803@redhat.com>
In-Reply-To: <4B28CA90.8050803@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH, RFC] Allow adding empty SCSI controllers
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Gerd Hoffmann wrote:
> On 12/15/09 18:30, Wolfgang Mauerer wrote:
>> Hi Gerd,
>>
>> in commit 5b684b5a56e81f6f, you introduced an explicit check
>> to prevent adding SCSI controllers without attached disks
>> to the system.
> 
> There was a patch from Daniel removing that check, isn't that one merged 
> meanwhile?  Hmm, looks like it isn't.
> 
> Your patch does more than just killing the check, especially the chunk 
> in lsi53c895a.c is clearly wrong.  I'd prefer Daniels patch being merged 
> instead.

after sending the patch, Daniel told me that he had already sent one,
and I don't care which one you merge as long as I can add empty
contollers again ;-)
> 
>> Is there any other method to introduce
>> disk-less controllers into the system?
> 
> device_add lsi,id=<hba-name>,addr=<slot.func>
> 
> adding disks then:
> 
> drive_add unused if=none,id=<disk-name>,file=...
> device_add scsi-disk,drive=<disk-name>,bus=<hba-name>.0,scsi-id=<nr>
> 
> Note that this is the only way you can expect to work reliable with more 
> than one scsi adapter being present in the system.

Thanks!

Cheers, Wolfgang