From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NLDma-0001z3-92
	for qemu-devel@nongnu.org; Thu, 17 Dec 2009 05:40:32 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NLDmU-0001w4-UR
	for qemu-devel@nongnu.org; Thu, 17 Dec 2009 05:40:31 -0500
Received: from [199.232.76.173] (port=42865 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NLDmU-0001vp-Dd
	for qemu-devel@nongnu.org; Thu, 17 Dec 2009 05:40:26 -0500
Received: from mx1.redhat.com ([209.132.183.28]:23006)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1NLDmU-0002L9-25
	for qemu-devel@nongnu.org; Thu, 17 Dec 2009 05:40:26 -0500
Message-ID: <4B2A0A8E.7050201@redhat.com>
Date: Thu, 17 Dec 2009 11:40:14 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: Proper support for PCI-based option rom loading (was
	Re:	[Qemu-devel] Re: qdev property bug?)
References: <4B26F678.4010603@codemonkey.ws> <4B27541F.9020603@redhat.com>
	<4B276197.1080606@redhat.com> <4B27E518.7060300@codemonkey.ws>
	<20091215211715.GF26712@redhat.com>
	<4B28026E.4060100@codemonkey.ws>
	<20091216045725.GC12410@morn.localdomain>
	<4B290951.20505@redhat.com>
	<20091217012434.GB11279@morn.localdomain>
	<4B29FDC9.4080109@redhat.com> <20091217095028.GC4905@redhat.com>
In-Reply-To: <20091217095028.GC4905@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Chris Wright <chrisw@redhat.com>, glommer@redhat.com, seabios@seabios.org, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Kevin O'Connor <kevin@koconnor.net>, Sebastian Herbszt <herbszt@gmx.de>

>>>> struct fw_files {
>>>>     u32 filecount;
>>>>     struct fw_file {
>>>>       u32  type;        /* vga, option, other? */
>>>>       u32  size;        /* file size */
>>>>       u32  select;      /* write this to 0x510 to read it */
>>>>       u32  reserved;    /* you never know ;) */
>>>>       char name[16];    /* maybe: filename */
>
> Can't name simply be null terminated?

It can, but it wouldn't be simple ...

cheers,
   Gerd