From: Paolo Bonzini <pbonzini@redhat.com>
To: Andre Przywara <andre.przywara@amd.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] osdep: Fix runtime failure on older Linux kernels
Date: Fri, 18 Dec 2009 11:42:36 +0100 [thread overview]
Message-ID: <4B2B5C9C.9080406@redhat.com> (raw)
In-Reply-To: <1261129507-13244-1-git-send-email-andre.przywara@amd.com>
On 12/18/2009 10:45 AM, Andre Przywara wrote:
> If QEMU finds newer kernel header files on compilation time, it will use
> advertised features like pipe2 or SOCK_CLOEXEC by just doing a compile test.
> If later the executables are executed on an older kernel (<2.6.27,
> like Xen Dom0 2.6.18), then QEMU will fail on opening sockets and creating
> pipes and returns the rather unspecific "qemu_init_main_loop failed".
> This patch fixes this by checking the return values of these calls
> for EINVAL and ENOSYS and falling back to the older versions automatically.
Agreed, most other apps that use *_CLOEXEC do this (including glibc
itself and gnulib; the notable exception is APR and there were quite
some flames about this).
Paolo
next prev parent reply other threads:[~2009-12-18 10:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 9:45 [Qemu-devel] [PATCH] osdep: Fix runtime failure on older Linux kernels Andre Przywara
2009-12-18 10:42 ` Paolo Bonzini [this message]
2009-12-18 11:32 ` Kevin Wolf
2009-12-18 12:33 ` Andre Przywara
2009-12-18 12:37 ` [Qemu-devel] [PATCH v2] " Andre Przywara
2009-12-18 12:49 ` [Qemu-devel] " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2B5C9C.9080406@redhat.com \
--to=pbonzini@redhat.com \
--cc=andre.przywara@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).