From: Andre Przywara <andre.przywara@amd.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] osdep: Fix runtime failure on older Linux kernels
Date: Fri, 18 Dec 2009 13:33:10 +0100 [thread overview]
Message-ID: <4B2B7686.7070002@amd.com> (raw)
In-Reply-To: <4B2B6855.4050909@redhat.com>
Kevin Wolf wrote:
>>....
>> @@ -302,12 +306,14 @@ int qemu_accept(int s, struct sockaddr *addr, socklen_t *addrlen)
>>
>> #ifdef CONFIG_ACCEPT4
>> ret = accept4(s, addr, addrlen, SOCK_CLOEXEC);
>> -#else
>> + if (ret != -1 || errno != EINVAL) {
>
> Shouldn't this be an ENOSYS?
Oh, right you are. This was the untested part, because my glibc didn't
have accept4. I only saw the SOCK_CLOEXEC name on this...
Fixed patch follows...
Regards,
Andre.
--
Andre Przywara
AMD-OSRC (Dresden)
Tel: x29712
next prev parent reply other threads:[~2009-12-18 12:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 9:45 [Qemu-devel] [PATCH] osdep: Fix runtime failure on older Linux kernels Andre Przywara
2009-12-18 10:42 ` [Qemu-devel] " Paolo Bonzini
2009-12-18 11:32 ` [Qemu-devel] " Kevin Wolf
2009-12-18 12:33 ` Andre Przywara [this message]
2009-12-18 12:37 ` [Qemu-devel] [PATCH v2] " Andre Przywara
2009-12-18 12:49 ` [Qemu-devel] " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2B7686.7070002@amd.com \
--to=andre.przywara@amd.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).