From: Anthony Liguori <anthony@codemonkey.ws>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: seabios@seabios.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [SeaBIOS] [PATCH 0/4] qemu option loading
Date: Fri, 18 Dec 2009 10:22:05 -0600 [thread overview]
Message-ID: <4B2BAC2D.4090605@codemonkey.ws> (raw)
In-Reply-To: <4B2BA528.9080104@redhat.com>
Gerd Hoffmann wrote:
> On 12/18/09 16:41, Anthony Liguori wrote:
>> I needed the following patch for this series to build:
>>
>> --- a/src/optionroms.c
>> +++ b/src/optionroms.c
>> @@ -13,6 +13,7 @@
>> +#include "paravirt.h" // qemu_cfg_*
>
>> --- a/src/paravirt.h
>> +++ b/src/paravirt.h
>> +u32 qemu_cfg_read_file(QemuCfgFile *entry, void *dst, u32 maxlen);
>
> Patch is very reasonable.
>
> /me wonders how it did build for me without warning about the missing
> prototype ...
I think your fw_cfg.h changes also broke the optionroms/multiboot
build. Haven't debugged yet though.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-12-18 16:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 11:16 [Qemu-devel] [PATCH 0/4] qemu option loading Gerd Hoffmann
2009-12-18 11:16 ` [Qemu-devel] [PATCH 1/4] Do not guard qemu shadow ram work around in CONFIG_OPTIONROMS_DEPLOYED Gerd Hoffmann
2009-12-18 11:16 ` [Qemu-devel] [PATCH 2/4] Disable CONFIG_OPTIONROMS_DEPLOYED by default Gerd Hoffmann
2009-12-18 11:16 ` [Qemu-devel] [PATCH 3/4] move htonl() + friends to util.h Gerd Hoffmann
2009-12-18 11:16 ` [Qemu-devel] [PATCH 4/4] qemu: add rom loading via fw_cfg Gerd Hoffmann
2009-12-18 15:41 ` [Qemu-devel] Re: [SeaBIOS] [PATCH 0/4] qemu option loading Anthony Liguori
2009-12-18 15:52 ` Gerd Hoffmann
2009-12-18 16:22 ` Anthony Liguori [this message]
2009-12-18 16:37 ` Gerd Hoffmann
2009-12-18 23:40 ` Kevin O'Connor
2009-12-19 0:37 ` Kevin O'Connor
2009-12-19 2:55 ` Anthony Liguori
2009-12-19 3:37 ` Kevin O'Connor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2BAC2D.4090605@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).