From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NLfap-0003dU-9A
	for qemu-devel@nongnu.org; Fri, 18 Dec 2009 11:22:15 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NLfak-0003X3-I7
	for qemu-devel@nongnu.org; Fri, 18 Dec 2009 11:22:14 -0500
Received: from [199.232.76.173] (port=57687 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NLfak-0003Wp-54
	for qemu-devel@nongnu.org; Fri, 18 Dec 2009 11:22:10 -0500
Received: from mail-yw0-f171.google.com ([209.85.211.171]:35396)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NLfaj-0003NO-TQ
	for qemu-devel@nongnu.org; Fri, 18 Dec 2009 11:22:10 -0500
Received: by ywh1 with SMTP id 1so3051858ywh.18
	for <qemu-devel@nongnu.org>; Fri, 18 Dec 2009 08:22:09 -0800 (PST)
Message-ID: <4B2BAC2D.4090605@codemonkey.ws>
Date: Fri, 18 Dec 2009 10:22:05 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1261134964-12427-1-git-send-email-kraxel@redhat.com>
	<4B2BA2B4.3030508@codemonkey.ws> <4B2BA528.9080104@redhat.com>
In-Reply-To: <4B2BA528.9080104@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [SeaBIOS] [PATCH 0/4] qemu option loading
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: seabios@seabios.org, qemu-devel@nongnu.org

Gerd Hoffmann wrote:
> On 12/18/09 16:41, Anthony Liguori wrote:
>> I needed the following patch for this series to build:
>>
>> --- a/src/optionroms.c
>> +++ b/src/optionroms.c
>> @@ -13,6 +13,7 @@
>> +#include "paravirt.h" // qemu_cfg_*
>
>> --- a/src/paravirt.h
>> +++ b/src/paravirt.h
>> +u32 qemu_cfg_read_file(QemuCfgFile *entry, void *dst, u32 maxlen);
>
> Patch is very reasonable.
>
> /me wonders how it did build for me without warning about the missing 
> prototype ...

I think your fw_cfg.h changes also broke the optionroms/multiboot 
build.  Haven't debugged yet though.

Regards,

Anthony Liguori