qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Laurent Desnogues <laurent.desnogues@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH 4/6] tcg-i386: Implement small forward branches.
Date: Fri, 18 Dec 2009 09:16:57 -0800	[thread overview]
Message-ID: <4B2BB909.7050103@twiddle.net> (raw)
In-Reply-To: <761ea48b0912180339p111e052cuca152598ef86dc0e@mail.gmail.com>

On 12/18/2009 03:39 AM, Laurent Desnogues wrote:
> To be consistent with the rest I'd use:
>
>    if (small)
>      tcg_abort();

Ok.

>> +            tcg_out8(s, 0x0f);
>
> I don't think this prefix should be output.

Oops.  Paste-o.


r~

  reply	other threads:[~2009-12-18 17:17 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <761ea48b0912170620l534dcb02m8ea6b59524d76dbe@mail.gmail.com>
2009-12-17 19:32 ` [Qemu-devel] [PATCH 0/6] tcg conditional set/move, round 2 Richard Henderson
2009-12-17 17:27   ` [Qemu-devel] [PATCH 1/6] tcg: Generic support for conditional set and conditional move Richard Henderson
2009-12-17 20:50     ` malc
2009-12-18 11:38     ` [Qemu-devel] " Laurent Desnogues
2009-12-17 17:28   ` [Qemu-devel] [PATCH 2/6] tcg: Add tcg_invert_cond Richard Henderson
2009-12-18 11:39     ` [Qemu-devel] " Laurent Desnogues
2009-12-17 17:32   ` [Qemu-devel] [PATCH 3/6] tcg-x86_64: Implement setcond and movcond Richard Henderson
2009-12-18 11:39     ` [Qemu-devel] " Laurent Desnogues
2009-12-18 17:11       ` Richard Henderson
2009-12-18 17:41         ` Laurent Desnogues
2009-12-17 17:55   ` [Qemu-devel] [PATCH 4/6] tcg-i386: Implement small forward branches Richard Henderson
2009-12-18 11:39     ` [Qemu-devel] " Laurent Desnogues
2009-12-18 17:16       ` Richard Henderson [this message]
2009-12-17 18:38   ` [Qemu-devel] [PATCH 5/6] tcg-i386: Simplify brcond2 Richard Henderson
2009-12-18 11:40     ` [Qemu-devel] " Laurent Desnogues
2009-12-18 17:45       ` Richard Henderson
2009-12-17 19:08   ` [Qemu-devel] [PATCH 6/6] tcg-i386: Implement setcond, movcond, setcond2 Richard Henderson
2009-12-18 11:37   ` [Qemu-devel] Re: [PATCH 0/6] tcg conditional set/move, round 2 Laurent Desnogues
2009-12-18 21:38     ` [Qemu-devel] tcg conditional set/move, round 3 Richard Henderson
2009-12-19 11:40       ` [Qemu-devel] " Laurent Desnogues
2009-12-19 16:09         ` Richard Henderson
2009-12-19 12:09       ` [Qemu-devel] " Andreas Färber
2009-12-19 13:03       ` Aurelien Jarno
2009-12-19 13:32         ` Aurelien Jarno
2009-12-19 16:19         ` Richard Henderson
2009-12-19 23:02           ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B2BB909.7050103@twiddle.net \
    --to=rth@twiddle.net \
    --cc=laurent.desnogues@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).