From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NLgRo-0005UX-Em
	for qemu-devel@nongnu.org; Fri, 18 Dec 2009 12:17:00 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NLgRn-0005Te-JQ
	for qemu-devel@nongnu.org; Fri, 18 Dec 2009 12:16:59 -0500
Received: from [199.232.76.173] (port=38986 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NLgRn-0005TV-C6
	for qemu-devel@nongnu.org; Fri, 18 Dec 2009 12:16:59 -0500
Received: from are.twiddle.net ([75.149.56.221]:46111)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rth@twiddle.net>) id 1NLgRm-0000qr-Vj
	for qemu-devel@nongnu.org; Fri, 18 Dec 2009 12:16:59 -0500
Message-ID: <4B2BB909.7050103@twiddle.net>
Date: Fri, 18 Dec 2009 09:16:57 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 4/6] tcg-i386: Implement small forward
	branches.
References: <761ea48b0912170620l534dcb02m8ea6b59524d76dbe@mail.gmail.com>	<cover.1261078375.git.rth@twiddle.net>	<89dbe5fc9e003225157911e8ad8b19b73cae7177.1261078375.git.rth@twiddle.net>
	<761ea48b0912180339p111e052cuca152598ef86dc0e@mail.gmail.com>
In-Reply-To: <761ea48b0912180339p111e052cuca152598ef86dc0e@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Desnogues <laurent.desnogues@gmail.com>
Cc: qemu-devel@nongnu.org

On 12/18/2009 03:39 AM, Laurent Desnogues wrote:
> To be consistent with the rest I'd use:
>
>    if (small)
>      tcg_abort();

Ok.

>> +            tcg_out8(s, 0x0f);
>
> I don't think this prefix should be output.

Oops.  Paste-o.


r~