From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NLgtR-0002Gg-G8 for qemu-devel@nongnu.org; Fri, 18 Dec 2009 12:45:33 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NLgtR-0002FG-0G for qemu-devel@nongnu.org; Fri, 18 Dec 2009 12:45:33 -0500 Received: from [199.232.76.173] (port=39663 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NLgtQ-0002Ew-He for qemu-devel@nongnu.org; Fri, 18 Dec 2009 12:45:32 -0500 Received: from are.twiddle.net ([75.149.56.221]:39413) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NLgtQ-0003QB-4k for qemu-devel@nongnu.org; Fri, 18 Dec 2009 12:45:32 -0500 Message-ID: <4B2BBFBA.1050305@twiddle.net> Date: Fri, 18 Dec 2009 09:45:30 -0800 From: Richard Henderson MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 5/6] tcg-i386: Simplify brcond2. References: <761ea48b0912170620l534dcb02m8ea6b59524d76dbe@mail.gmail.com> <38131b3a03ff4872a19c52b5c042dd7d77341b75.1261078375.git.rth@twiddle.net> <761ea48b0912180340w64e247bdsaa4401ba8d161ae3@mail.gmail.com> In-Reply-To: <761ea48b0912180340w64e247bdsaa4401ba8d161ae3@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Desnogues Cc: qemu-devel@nongnu.org On 12/18/2009 03:40 AM, Laurent Desnogues wrote: > I'm not sure I really like that rewrite, I find it hard to read. > Convince me it's better :-) Would it be more obvious if I used a table instead of a switch? The code size reduction is Num: Value Size Type Bind Vis Ndx Name before: 40: 000039a0 793 FUNC LOCAL DEFAULT 1 tcg_out_brcond2 after: 40: 00003a50 412 FUNC LOCAL DEFAULT 1 tcg_out_brcond2 table-ized: 40: 00003a50 224 FUNC LOCAL DEFAULT 1 tcg_out_brcond2 But I'm not married to the patch; let's drop it if there's a question of it holding up the rest of the series. r~