From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NM8AR-0001lt-F7
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 17:52:55 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NM8AQ-0001lZ-Nh
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 17:52:55 -0500
Received: from [199.232.76.173] (port=46942 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NM8AQ-0001lW-Ld
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 17:52:54 -0500
Received: from are.twiddle.net ([75.149.56.221]:36422)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rth@twiddle.net>) id 1NM8AQ-0000Wu-96
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 17:52:54 -0500
Message-ID: <4B2D5944.9000704@twiddle.net>
Date: Sat, 19 Dec 2009 14:52:52 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 5/7] tcg-sparc: Implement setcond, movcond,
	setcond2, brcond2.
References: <cover.1261012798.git.rth@twiddle.net>
	<4259c837ce1a62fcb495e57f18b588eb7365d286.1261012798.git.rth@twiddle.net>
	<f43fc5580912190231n633a6c76id096810ca2af3a14@mail.gmail.com>
	<4B2D11C8.6040507@twiddle.net>
	<f43fc5580912191325h788cf6e8kd3cacbe3779be06f@mail.gmail.com>
In-Reply-To: <f43fc5580912191325h788cf6e8kd3cacbe3779be06f@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

On 12/19/2009 01:25 PM, Blue Swirl wrote:
> On Sat, Dec 19, 2009 at 5:47 PM, Richard Henderson<rth@twiddle.net>  wrote:
>> On 12/19/2009 02:31 AM, Blue Swirl wrote:
>>>>
>>>>   static inline void tcg_out_movi_imm32(TCGContext *s, int ret, uint32_t
>>>> arg)
>>>>   {
>>>> -    if (check_fit_tl(arg, 12))
>>>> +    if (check_fit_tl(arg, 13))
>>>>          tcg_out_movi_imm13(s, ret, arg);
>>>
>>> IIRC sign extension prevents this.
>>
>> Pardon?  check_fit_tl checks a signed value, the OR opcode provides one.
>>   Where's the conflict?
>
> Long time ago I tried the same change, but the generated code was not
> correct. But now it seems to work.

I can't imagine why.  I've looked at the instruction encodings very 
carefully and double-checked the arithmetic vs GCC.

I still think the change is correct.  I can probably dig up access to a 
sparc machine and verify, but I don't know that would convince you.


r~