From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NM8ev-0000qF-27 for qemu-devel@nongnu.org; Sat, 19 Dec 2009 18:24:25 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NM8eu-0000ps-Dx for qemu-devel@nongnu.org; Sat, 19 Dec 2009 18:24:24 -0500 Received: from [199.232.76.173] (port=36433 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NM8eu-0000pn-8b for qemu-devel@nongnu.org; Sat, 19 Dec 2009 18:24:24 -0500 Received: from are.twiddle.net ([75.149.56.221]:57457) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NM8eu-0002d8-1P for qemu-devel@nongnu.org; Sat, 19 Dec 2009 18:24:24 -0500 Message-ID: <4B2D60A6.6070907@twiddle.net> Date: Sat, 19 Dec 2009 15:24:22 -0800 From: Richard Henderson MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/5] tcg: Generic support for conditional set References: <08eb5a18dde9c9a676073d179003398473ca311c.1261248772.git.rth@twiddle.net> <20091219231122.GA32752@volta.aurel32.net> In-Reply-To: <20091219231122.GA32752@volta.aurel32.net> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 12/19/2009 03:11 PM, Aurelien Jarno wrote: > On Sat, Dec 19, 2009 at 10:01:57AM -0800, Richard Henderson wrote: >> Defines setcond_{i32,i64} and setcond2_i32 for 64-on-32-bit. > > I do wonder if setcond2_i32 and brcond2_i32 should be added there. Those > are internal ops that are actually not exported in tcg-op.h. I think it's probably useful documentation, even if it is internal. One does have to know what it means in order to implement it in the backends. r~