From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NMAQK-00045L-Tv
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 20:17:28 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NMAQK-000451-5m
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 20:17:28 -0500
Received: from [199.232.76.173] (port=39243 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NMAQK-00044y-1z
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 20:17:28 -0500
Received: from are.twiddle.net ([75.149.56.221]:58153)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rth@twiddle.net>) id 1NMAQJ-0001gv-QJ
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 20:17:27 -0500
Message-ID: <4B2D7B25.8090205@twiddle.net>
Date: Sat, 19 Dec 2009 17:17:25 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/5] tcg-i386: Implement small forward
	branches.
References: <cover.1261248772.git.rth@twiddle.net>	
	<9f38711e7d93ded68cad15e5cdbeecbf2c9ae521.1261248772.git.rth@twiddle.net>
	<761ea48b0912191532n4aaf019drd2fc5d06f74b6fe7@mail.gmail.com>
In-Reply-To: <761ea48b0912191532n4aaf019drd2fc5d06f74b6fe7@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Desnogues <laurent.desnogues@gmail.com>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net

On 12/19/2009 03:32 PM, Laurent Desnogues wrote:
>>      switch(args[4]) {
>>      case TCG_COND_EQ:
>> -        tcg_out_brcond(s, TCG_COND_NE, args[0], args[2], const_args[2], label_next);
>> -        tcg_out_brcond(s, TCG_COND_EQ, args[1], args[3], const_args[3], args[5]);
>> +        tcg_out_brcond(s, TCG_COND_NE, args[0], args[2], const_args[2],
>> +                       label_next, small);
>
> Shouldn't it be 1 instead of small?

Sigh, yes indeed.


r~