From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NMNnu-0005py-Az
	for qemu-devel@nongnu.org; Sun, 20 Dec 2009 10:34:42 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NMNnp-0005ng-Gc
	for qemu-devel@nongnu.org; Sun, 20 Dec 2009 10:34:42 -0500
Received: from [199.232.76.173] (port=53035 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NMNnp-0005nW-AN
	for qemu-devel@nongnu.org; Sun, 20 Dec 2009 10:34:37 -0500
Received: from mail-yw0-f171.google.com ([209.85.211.171]:52348)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NMNno-0007gg-VQ
	for qemu-devel@nongnu.org; Sun, 20 Dec 2009 10:34:37 -0500
Received: by ywh1 with SMTP id 1so4200471ywh.18
	for <qemu-devel@nongnu.org>; Sun, 20 Dec 2009 07:34:36 -0800 (PST)
Message-ID: <4B2E4409.4050809@codemonkey.ws>
Date: Sun, 20 Dec 2009 09:34:33 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/8] Support PCI based option rom loading
References: <1261134074-11795-1-git-send-email-kraxel@redhat.com>
	<1261134074-11795-2-git-send-email-kraxel@redhat.com>
	<f43fc5580912190257i1c7fd33at46853eb5340158be@mail.gmail.com>
In-Reply-To: <f43fc5580912190257i1c7fd33at46853eb5340158be@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, seabios@seabios.org, Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org

Blue Swirl wrote:
> On Fri, Dec 18, 2009 at 11:01 AM, Gerd Hoffmann <kraxel@redhat.com> wrote:
>   
>> From: Anthony Liguori <aliguori@us.ibm.com>
>>
>> Currently, we preload option roms into the option rom space in memory.  This
>> prevents DDIM from functioning correctly which severely limits the number
>> of roms we can support.
>>
>> This patch introduces a pci_add_option_rom() which registers the
>> PCI_ROM_ADDRESS bar which points to our option rom.  It also converts over
>> the cirrus vga adapter, the rtl8139, virtio, and the e1000 to use this
>> new mechanism.
>>     
>
> This means that the VGA roms are now visible for all targets, not just
> when rom_enable_driver_roms is true. I'm not opposing this, but it may
> create regressions.
>   

This is pretty normal on bare metal though, no?  I thought a lot of 
non-x86 systems actually use x86 emulators specifically to enable 
support for these roms.

Regards,

Anthony Liguori