From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NN1EY-0002vM-NU for qemu-devel@nongnu.org; Tue, 22 Dec 2009 04:40:50 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NN1EU-0002ts-Ee for qemu-devel@nongnu.org; Tue, 22 Dec 2009 04:40:50 -0500 Received: from [199.232.76.173] (port=37871 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NN1EU-0002tn-8N for qemu-devel@nongnu.org; Tue, 22 Dec 2009 04:40:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7692) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NN1EP-0001f0-2t for qemu-devel@nongnu.org; Tue, 22 Dec 2009 04:40:46 -0500 Message-ID: <4B309402.3010207@redhat.com> Date: Tue, 22 Dec 2009 11:40:18 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH master, stable-0.12] Don't load options roms intended to be loaded by the bios in qemu References: <1261473913-28442-1-git-send-email-avi@redhat.com> <20091222093554.GC31094@hall.aurel32.net> In-Reply-To: <20091222093554.GC31094@hall.aurel32.net> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 12/22/2009 11:35 AM, Aurelien Jarno wrote: > On Tue, Dec 22, 2009 at 11:25:13AM +0200, Avi Kivity wrote: > >> The first such option rom will load at address 0, which isn't very nice, >> and the second will report a conflict and abort, which is horrible. >> >> Signed-off-by: Avi Kivity >> --- >> hw/loader.c | 3 +++ >> 1 files changed, 3 insertions(+), 0 deletions(-) >> >> diff --git a/hw/loader.c b/hw/loader.c >> index 2ceb8eb..c6bf0f1 100644 >> --- a/hw/loader.c >> +++ b/hw/loader.c >> @@ -654,6 +654,9 @@ int rom_load_all(void) >> Rom *rom; >> >> QTAILQ_FOREACH(rom,&roms, next) { >> + if (!rom->addr) { >> + continue; >> + } >> > Some roms needs to be loaded at address 0, it's the case for example of > the arm versatile bootloader. Adding this code will break the board > emulation. > The idea of keying bios-loading or host-loading on address is broken (another instance of mixing control and data). We need a separate control for this. I'll leave this to the authors of the code as I can't make heads or tails of it. -- error compiling committee.c: too many arguments to function