From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NNC8L-0001xN-Nm for qemu-devel@nongnu.org; Tue, 22 Dec 2009 16:19:09 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NNC8H-0001tS-1M for qemu-devel@nongnu.org; Tue, 22 Dec 2009 16:19:09 -0500 Received: from [199.232.76.173] (port=33152 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NNC8G-0001tI-SE for qemu-devel@nongnu.org; Tue, 22 Dec 2009 16:19:04 -0500 Received: from qw-out-1920.google.com ([74.125.92.145]:13018) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NNC8G-0006Ww-Lg for qemu-devel@nongnu.org; Tue, 22 Dec 2009 16:19:04 -0500 Received: by qw-out-1920.google.com with SMTP id 5so1105671qwc.4 for ; Tue, 22 Dec 2009 13:19:03 -0800 (PST) Message-ID: <4B3137C4.5090403@codemonkey.ws> Date: Tue, 22 Dec 2009 15:19:00 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/3] virtio-console: Add a virtio-serial bus, support for multiple devices and ports References: <1261504146-26018-1-git-send-email-amit.shah@redhat.com> <1261504146-26018-2-git-send-email-amit.shah@redhat.com> <1261504146-26018-3-git-send-email-amit.shah@redhat.com> In-Reply-To: <1261504146-26018-3-git-send-email-amit.shah@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: agraf@suse.de, kraxel@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On 12/22/2009 11:49 AM, Amit Shah wrote: > This patch migrates virtio-console to the qdev infrastructure and > creates a new virtio-serial bus on which multiple ports are exposed as > devices. The bulk of the code now resides in a new file with > virtio-console.c being just a simple qdev device. > > This interface enables spawning of multiple virtio consoles as well as generic > serial ports. > > The older -virtconsole argument still works, but when using the new > functionality, it is recommended to use > > -device virtio-serial-pci -device virtconsole,... > > The virtconsole device type accepts a chardev as an argument and a 'name' > argument to identify the corresponding consoles on the host as well as the > guest. The name, if given, is exposed via the 'name' sysfs attribute in the > guest. > > Care has been taken to ensure compatibility with kernels that do not > support multiple ports as well as accepting incoming migrations from older > qemu versions. > > Signed-off-by: Amit Shah This is really difficult to review. If you're introducing a completely new file, why don't you just call it virtio-serial.c and delete virtio-console.c It will save quite a bit of reviewing head ache. Regards, Anthony Liguori