From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NRnrN-0007au-4k for qemu-devel@nongnu.org; Mon, 04 Jan 2010 09:24:41 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NRnrI-0007Zx-Mo for qemu-devel@nongnu.org; Mon, 04 Jan 2010 09:24:40 -0500 Received: from [199.232.76.173] (port=56669 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NRnrI-0007Zu-I4 for qemu-devel@nongnu.org; Mon, 04 Jan 2010 09:24:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:2480) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NRnrI-0007kR-2Y for qemu-devel@nongnu.org; Mon, 04 Jan 2010 09:24:36 -0500 Message-ID: <4B41FA12.9040806@redhat.com> Date: Mon, 04 Jan 2010 15:24:18 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <20091224124427.GC31553@redhat.com> In-Reply-To: <20091224124427.GC31553@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCHv4 2/2] virtio: add features as qdev properties List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On 12/24/09 13:44, Michael S. Tsirkin wrote: > Add feature bits as properties to virtio. This makes it possible to e.g. define > machine without indirect buffer support, which is required for 0.10 > compatibility, or without hardware checksum support, which is required for 0.11 > compatibility. Since default values for optional features are now set by qdev, > get_features callback has been modified: it sets non-optional bits, and clears > bits not supported by host. I guess you'll need a bunch of entries for pc-0.10 and pc-0.11 to switch the virtio devices into the correct compatibility modes? Should probably go as patch #3 of this series. cheers, Gerd